Avoid exception when __frame_data["code_context"] is None #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 4 4
Lines 182 182
=======================================
Hits 171 171
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
Thanks @dschult! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of
DelayedImportErrorModule, an exception message is created forModuleNotFound. That message creation uses__frame_dataincludingcode_context. But it raises a secondary TypeError exception iffd["code_context'] is None.This PR handles the case of no
code_contextby addingor ""to getfd["code_context"] or ""See networkx/networkx#7062
I wasn't able to make a test for this easily because I don't know how to create some code for a test with code_context showing up as None. But this change is presumably harmless at worst and hopes to reduce confusion when a moduleNotFound error is raised for a
DelayedImportErrorModule.