Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scientific-python/upload-nightly-action
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.2.0
Choose a base ref
...
head repository: scientific-python/upload-nightly-action
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.3.0
Choose a head ref
  • 6 commits
  • 4 files changed
  • 4 contributors

Commits on Oct 6, 2023

  1. DOC: Update action commit SHA to the 0.2.0 tag (#44)

    * For stability provide the commit SHA that corresponds to the 0.2.0
      tag for users to pin to.
    matthewfeickert authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    ee502b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. CI: Bump actions/setup-python from 4 to 5 (#48)

    Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
    - [Release notes](https://github.com/actions/setup-python/releases)
    - [Commits](actions/setup-python@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-python
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    a337403 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. ENH: Add optional anaconda_nightly_upload_organization argument (#47)

    * NF: Add anaconda_nightly_upload_url parameter
    NF: add anaconda_nightly_upload_token paremeter
    DOC: Add associated documentation
    
    * DOC: add labels documentation
    
    * Apply suggestions from code review
    
    Co-authored-by: Stefan van der Walt <[email protected]>
    
    * - address stefanv comments.
    - rename anaconda_nightly_upload_url to anaconda_nightly_upload_organization
    
    * FIX: del list, docker handle only str/bool/number
    - parse string in case of multiple labels
    
    * Handle comma and new line seperated label lists
    
    Using space seperated lists is not standard across GitHub Actions, which in general assume that you're providing a newline seperatd or comma seperated list (c.f. https://github.com/docker/build-push-action?tab=readme-ov-file#inputs as an example).
    
    So if we agree that we should be expecting newline seperated or comma seperated inputs then we can just treat all input the same by:
    
    First, converting all input into a comma separated string
    Then, create an array of the comma seperated labels
    Finally, parse that array into a single string that represents all the label arguments to be included (you were already doing this part)
    
    ---------
    
    Co-authored-by: Stefan van der Walt <[email protected]>
    Co-authored-by: Matthew Feickert <[email protected]>
    3 people authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f689fba View commit details
    Browse the repository at this point in the history
  2. FIX: Use correct shell variable in upload (#53)

    * Use the correct shell variable "LABEL_ARGS" to pass the lable args to
      the `anaconda upload` command.
       - Amends PR #47
    * Note that it is important that ${LABEL_ARGS} is NOT quoted during
      shell parameter expansion, else it will be treated as a file path to
      anaconda upload and not an argument.
       - e.g. This will trigger `File "--label main " does not exist`
         errors.
    matthewfeickert authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    3eb3a42 View commit details
    Browse the repository at this point in the history
  3. CI: Add test for uploads with multiple labels (#54)

    * Add test uploads for non-main label 'test' and for multiple labels in
      a comma seperated list. As attempting to apply multiple labels through
      repeated upload of the same package will fail as the package already
      exists, bump the version number of the test package to generate
      multiple packages that can be uploaded with different labels.
    matthewfeickert authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    b579d79 View commit details
    Browse the repository at this point in the history
  4. FIX: Remove environment print for security (#55)

    * As 'env' prints the entire environment this is a route to accidentally
      leak secrets into public logs. While GitHub properly screens secrets
      it would be better to not provide a chance for something to go wrong.
    matthewfeickert authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6e9304f View commit details
    Browse the repository at this point in the history
Loading