-
Notifications
You must be signed in to change notification settings - Fork 10
Description
We pin everything to hashes in here, please do so with this one, too.
Originally posted by @bsipocz in #101 (comment)
I was decently vocal about wanting stringent locking of things inside of Linux containers and for the upload-nightly-action
in PR #13, but I am less convinced that trying to pin every GitHub Action to the hash level is a useful or even good idea (there are some that you definitely do want to pin, but I don't think this applies to all).
I should write a more comprehensive overview of what I'm thinking here when it is a more reasonable time of day, but the core point is that (as @henryiii describes in davidism/gha-update#3 (comment)) GitHub Actions is not a static platform like Travis CI tried to be, and pinning everything at the hash level when the underlying runner operating system floats with no user control is arguably worse (in that it can lead to breakages) than having different levels of tolerance for GitHub Action versions depending on the action.
I'm hoping that other people have thought more on this than I have though, so it would be great to get everyone's thoughts, examples of thing working given choices, and (most educational for me) examples of things breaking because of choices.