FIX change FutureWarnings to DeprecationWarnings for the tags (#30573)

glemaitre · jeremiedbb · commit 0d2ce432de05 · 2025-01-09T16:12:35.000+01:00
diff --git a/doc/whats_new/upcoming_changes/many-modules/30573.fix.rst b/doc/whats_new/upcoming_changes/many-modules/30573.fix.rst
@@ -0,0 +1,4 @@
+- `_more_tags`, `_get_tags`, and `_safe_tags` are now raising a
+  :class:`DeprecationWarning` instead of a :class:`FutureWarning` to only notify
+  developers instead of end-users.
+  By :user:`Guillaume Lemaitre <glemaitre>` in
diff --git a/sklearn/base.py b/sklearn/base.py
@@ -400,7 +400,7 @@ def _more_tags(self):
         warnings.warn(
             "The `_more_tags` method is deprecated in 1.6 and will be removed in "
             "1.7. Please implement the `__sklearn_tags__` method.",
-            category=FutureWarning,
+            category=DeprecationWarning,
         )
         return _to_old_tags(default_tags(self))
 
@@ -411,7 +411,7 @@ def _get_tags(self):
         warnings.warn(
             "The `_get_tags` method is deprecated in 1.6 and will be removed in "
             "1.7. Please implement the `__sklearn_tags__` method.",
-            category=FutureWarning,
+            category=DeprecationWarning,
         )
 
         return _to_old_tags(get_tags(self))
diff --git a/sklearn/utils/_tags.py b/sklearn/utils/_tags.py
@@ -359,7 +359,7 @@ def _find_tags_provider(estimator, warn=True):
             "`sklearn.base.ClassifierMixin`, `sklearn.base.RegressorMixin`, and "
             "`sklearn.base.OutlierMixin`. From scikit-learn 1.7, not defining "
             "`__sklearn_tags__` will raise an error.",
-            category=FutureWarning,
+            category=DeprecationWarning,
         )
     return tag_provider
 
@@ -446,7 +446,7 @@ def _safe_tags(estimator, key=None):
         "The `_safe_tags` function is deprecated in 1.6 and will be removed in "
         "1.7. Use the public `get_tags` function instead and make sure to implement "
         "the `__sklearn_tags__` method.",
-        category=FutureWarning,
+        category=DeprecationWarning,
     )
     tags = _to_old_tags(get_tags(estimator))
 
diff --git a/sklearn/utils/tests/test_tags.py b/sklearn/utils/tests/test_tags.py
@@ -40,7 +40,9 @@ class EmptyRegressor(RegressorMixin, BaseEstimator):
     pass
 
 
-@pytest.mark.filterwarnings("ignore:.*no __sklearn_tags__ attribute.*:FutureWarning")
+@pytest.mark.filterwarnings(
+    "ignore:.*no __sklearn_tags__ attribute.*:DeprecationWarning"
+)
 @pytest.mark.parametrize(
     "estimator, value",
     [
@@ -169,7 +171,7 @@ def test_get_tags_backward_compatibility():
     predictor_classes = [PredictorNewTags, PredictorOldNewTags, PredictorOldTags]
     for predictor_cls in predictor_classes:
         if predictor_cls.__name__.endswith("OldTags"):
-            with pytest.warns(FutureWarning, match=warn_msg):
+            with pytest.warns(DeprecationWarning, match=warn_msg):
                 tags = get_tags(predictor_cls())
         else:
             tags = get_tags(predictor_cls())
@@ -194,7 +196,7 @@ class ChildClass(allow_nan_cls, predictor_cls):
                 base_cls.__name__.endswith("OldTags")
                 for base_cls in (predictor_cls, allow_nan_cls)
             ):
-                with pytest.warns(FutureWarning, match=warn_msg):
+                with pytest.warns(DeprecationWarning, match=warn_msg):
                     tags = get_tags(ChildClass())
             else:
                 tags = get_tags(ChildClass())
@@ -227,7 +229,7 @@ class ChildClass(allow_nan_cls, array_api_cls, predictor_cls):
                     base_cls.__name__.endswith("OldTags")
                     for base_cls in (predictor_cls, array_api_cls, allow_nan_cls)
                 ):
-                    with pytest.warns(FutureWarning, match=warn_msg):
+                    with pytest.warns(DeprecationWarning, match=warn_msg):
                         tags = get_tags(ChildClass())
                 else:
                     tags = get_tags(ChildClass())
@@ -238,7 +240,7 @@ class ChildClass(allow_nan_cls, array_api_cls, predictor_cls):
 
 
 @pytest.mark.filterwarnings(
-    "ignore:.*Please define the `__sklearn_tags__` method.*:FutureWarning"
+    "ignore:.*Please define the `__sklearn_tags__` method.*:DeprecationWarning"
 )
 def test_safe_tags_backward_compatibility():
     warn_msg = "The `_safe_tags` function is deprecated in 1.6"
@@ -247,7 +249,7 @@ def test_safe_tags_backward_compatibility():
     # only predictor inheriting from BaseEstimator
     predictor_classes = [PredictorNewTags, PredictorOldNewTags, PredictorOldTags]
     for predictor_cls in predictor_classes:
-        with pytest.warns(FutureWarning, match=warn_msg):
+        with pytest.warns(DeprecationWarning, match=warn_msg):
             tags = _safe_tags(predictor_cls())
         assert tags["requires_fit"]
 
@@ -266,7 +268,7 @@ def test_safe_tags_backward_compatibility():
             class ChildClass(allow_nan_cls, predictor_cls):
                 pass
 
-            with pytest.warns(FutureWarning, match=warn_msg):
+            with pytest.warns(DeprecationWarning, match=warn_msg):
                 tags = _safe_tags(ChildClass())
 
             assert tags["allow_nan"]
@@ -293,7 +295,7 @@ class ChildClass(allow_nan_cls, predictor_cls):
                 class ChildClass(allow_nan_cls, array_api_cls, predictor_cls):
                     pass
 
-                with pytest.warns(FutureWarning, match=warn_msg):
+                with pytest.warns(DeprecationWarning, match=warn_msg):
                     tags = _safe_tags(ChildClass())
 
                 assert tags["allow_nan"]
@@ -302,7 +304,7 @@ class ChildClass(allow_nan_cls, array_api_cls, predictor_cls):
 
 
 @pytest.mark.filterwarnings(
-    "ignore:.*Please define the `__sklearn_tags__` method.*:FutureWarning"
+    "ignore:.*Please define the `__sklearn_tags__` method.*:DeprecationWarning"
 )
 def test__get_tags_backward_compatibility():
     warn_msg = "The `_get_tags` method is deprecated in 1.6"
@@ -311,7 +313,7 @@ def test__get_tags_backward_compatibility():
     # only predictor inheriting from BaseEstimator
     predictor_classes = [PredictorNewTags, PredictorOldNewTags, PredictorOldTags]
     for predictor_cls in predictor_classes:
-        with pytest.warns(FutureWarning, match=warn_msg):
+        with pytest.warns(DeprecationWarning, match=warn_msg):
             tags = predictor_cls()._get_tags()
         assert tags["requires_fit"]
 
@@ -330,7 +332,7 @@ def test__get_tags_backward_compatibility():
             class ChildClass(allow_nan_cls, predictor_cls):
                 pass
 
-            with pytest.warns(FutureWarning, match=warn_msg):
+            with pytest.warns(DeprecationWarning, match=warn_msg):
                 tags = ChildClass()._get_tags()
 
             assert tags["allow_nan"]
@@ -357,7 +359,7 @@ class ChildClass(allow_nan_cls, predictor_cls):
                 class ChildClass(allow_nan_cls, array_api_cls, predictor_cls):
                     pass
 
-                with pytest.warns(FutureWarning, match=warn_msg):
+                with pytest.warns(DeprecationWarning, match=warn_msg):
                     tags = ChildClass()._get_tags()
 
                 assert tags["allow_nan"]
@@ -376,29 +378,35 @@ def test_base_estimator_more_tags():
     `BaseEstimator`.
     """
     estimator = BaseEstimator()
-    with pytest.warns(FutureWarning, match="The `_more_tags` method is deprecated"):
+    with pytest.warns(
+        DeprecationWarning, match="The `_more_tags` method is deprecated"
+    ):
         more_tags = BaseEstimator._more_tags(estimator)
 
-    with pytest.warns(FutureWarning, match="The `_get_tags` method is deprecated"):
+    with pytest.warns(DeprecationWarning, match="The `_get_tags` method is deprecated"):
         get_tags = BaseEstimator._get_tags(estimator)
 
     assert more_tags == get_tags
 
 
 def test_safe_tags():
     estimator = PredictorNewTags()
-    with pytest.warns(FutureWarning, match="The `_safe_tags` function is deprecated"):
+    with pytest.warns(
+        DeprecationWarning, match="The `_safe_tags` function is deprecated"
+    ):
         tags = _safe_tags(estimator)
 
-    with pytest.warns(FutureWarning, match="The `_safe_tags` function is deprecated"):
+    with pytest.warns(
+        DeprecationWarning, match="The `_safe_tags` function is deprecated"
+    ):
         tags_requires_fit = _safe_tags(estimator, key="requires_fit")
 
     assert tags_requires_fit == tags["requires_fit"]
 
     err_msg = "The key unknown_key is not defined"
     with pytest.raises(ValueError, match=err_msg):
         with pytest.warns(
-            FutureWarning, match="The `_safe_tags` function is deprecated"
+            DeprecationWarning, match="The `_safe_tags` function is deprecated"
         ):
             _safe_tags(estimator, key="unknown_key")
 
