BLD Check build dependencies in meson.build (#28721)

glemaitre · jeremiedbb · glemaitre · commit 2190f042a89a · 2024-09-11T10:57:21.000+02:00
Co-authored-by: Jérémie du Boisberranger &lt;jeremie@probabl.ai&gt;
diff --git a/Makefile b/Makefile
@@ -26,6 +26,8 @@ inplace:
 dev-meson:
 	pip install --verbose --no-build-isolation --editable . --config-settings editable-verbose=true
 
+clean: clean-meson
+
 clean-meson:
 	pip uninstall -y scikit-learn
 
diff --git a/meson.build b/meson.build
@@ -13,6 +13,7 @@ project(
 
 cc = meson.get_compiler('c')
 cpp = meson.get_compiler('cpp')
+cython = meson.get_compiler('cython')
 
 # Check compiler is recent enough (see "Toolchain Roadmap" for details)
 if cc.get_id() == 'gcc'
diff --git a/pyproject.toml b/pyproject.toml
@@ -99,7 +99,7 @@ build-backend = "mesonpy"
 requires = [
     "meson-python>=0.16.0",
     "Cython>=3.0.10",
-    "numpy>=2.0.0rc2",
+    "numpy>=2",
     "scipy>=1.6.0",
 ]
 
diff --git a/sklearn/meson.build b/sklearn/meson.build
@@ -18,6 +18,41 @@ if is_mingw
   add_project_arguments('-mlong-double-64', language: 'c')
 endif
 
+# Only check build dependencies version when not cross-compiling, as running
+# Python interpreter can be tricky in cross-compilation settings. For more
+# details, see https://docs.scipy.org/doc/scipy/building/cross_compilation.html
+if not meson.is_cross_build()
+  if not py.version().version_compare('>=3.9')
+    error('scikit-learn requires Python>=3.9, got ' + py.version() + ' instead')
+  endif
+
+  cython_min_version = run_command(py, ['_min_dependencies.py', 'cython'], check: true).stdout().strip()
+  if not cython.version().version_compare('>=' + cython_min_version)
+    error('scikit-learn requires Cython>=' + cython_min_version + ', got ' + cython.version() + ' instead')
+  endif
+
+  meson_python_version = run_command(py,
+    ['-c', 'import mesonpy; print(mesonpy.__version__)'], check: true).stdout().strip()
+  meson_python_min_version = run_command(py, ['_min_dependencies.py', 'meson-python'], check: true).stdout().strip()
+  if not meson_python_version.version_compare('>=' + meson_python_min_version)
+    error('scikit-learn requires meson-python>=' + meson_python_min_version + ', got ' + meson_python_version + ' instead')
+  endif
+
+  numpy_version = run_command(py,
+    ['-c', 'import numpy; print(numpy.__version__)'], check: true).stdout().strip()
+  numpy_min_version = run_command(py, ['_min_dependencies.py', 'numpy'], check: true).stdout().strip()
+  if not numpy_version.version_compare('>=' + numpy_min_version)
+    error('scikit-learn requires numpy>=' + numpy_min_version + ', got ' + numpy_version + ' instead')
+  endif
+
+  scipy_version = run_command(py,
+    ['-c', 'import scipy; print(scipy.__version__)'], check: true).stdout().strip()
+  scipy_min_version = run_command(py, ['_min_dependencies.py', 'scipy'], check: true).stdout().strip()
+  if not scipy_version.version_compare('>=' + scipy_min_version)
+    error('scikit-learn requires scipy>=' + scipy_min_version + ', got ' + scipy_version + ' instead')
+  endif
+endif
+
 # Adapted from scipy, each project seems to have its own tweaks for this. One
 # day using dependency('numpy') will be a thing, see
 # https://github.com/mesonbuild/meson/issues/9598.

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ build-backend = "mesonpy"`
`99`	`99`	`requires = [`
`100`	`100`	`"meson-python>=0.16.0",`
`101`	`101`	`"Cython>=3.0.10",`
`102`		`- "numpy>=2.0.0rc2",`
	`102`	`+ "numpy>=2",`
`103`	`103`	`"scipy>=1.6.0",`
`104`	`104`	`]`
`105`	`105`