MAINT Parameters validation for sklearn.metrics.silhouette_samples (#26053)

dmitrylala · web-flow · commit a9b06a7cbfe3 · 2023-04-03T12:20:41.000+02:00
diff --git a/sklearn/metrics/cluster/_unsupervised.py b/sklearn/metrics/cluster/_unsupervised.py
@@ -14,8 +14,13 @@
 from ...utils import check_random_state
 from ...utils import check_X_y
 from ...utils import _safe_indexing
+from ...utils._param_validation import (
+    StrOptions,
+    validate_params,
+)
 from ..pairwise import pairwise_distances_chunked
 from ..pairwise import pairwise_distances
+from ..pairwise import _VALID_METRICS
 from ...preprocessing import LabelEncoder
 
 
@@ -172,6 +177,13 @@ def _silhouette_reduce(D_chunk, start, labels, label_freqs):
     return intra_cluster_distances, inter_cluster_distances
 
 
+@validate_params(
+    {
+        "X": ["array-like", "sparse matrix"],
+        "labels": ["array-like"],
+        "metric": [StrOptions(set(_VALID_METRICS) | {"precomputed"}), callable],
+    }
+)
 def silhouette_samples(X, labels, *, metric="euclidean", **kwds):
     """Compute the Silhouette Coefficient for each sample.
 
diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py
@@ -170,6 +170,7 @@ def _check_function_param_validation(
     "sklearn.metrics.classification_report",
     "sklearn.metrics.cluster.adjusted_mutual_info_score",
     "sklearn.metrics.cluster.contingency_matrix",
+    "sklearn.metrics.cluster.silhouette_samples",
     "sklearn.metrics.cohen_kappa_score",
     "sklearn.metrics.confusion_matrix",
     "sklearn.metrics.coverage_error",
