-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Description
While working on #11646 , I'm looking at the ElasticNetCV class and I humbly think the doc could be improved a bit:
-
It's not clear at first glance what's the difference between
ElasticNetCVandElasticNet + GridSearch + best_param_.- Will
ElasticNetCVrefit the model with the best parameters, or does it just find the best parameters (and it's up to the user to refit)? - From what I understand, the advantage of
ElasticNetCVis that it can take advantage of warm starting the estimators?
- Will
-
It's not obvious what a "regularization path" is (related to previous point I suppose)
-
The
n_alphasandalphasparameters are confusing because they're mutually exclusive but it's not mentioned explicitly.alphasseems to have priority overn_alpha. -
The
alphas_attribute advertisesThe grid of alphas used for fitting, for each l1_ratio, but in reality it's just thealphasparameter. So ifn_alphaswas set, I would exceptalphas_to display the automatically chosen alphas, but it's actually set toNone.
I'd be happy to submit a PR if that's OK, I just want to make sure that I'm not missing something.