Thanks to visit codestin.com
Credit goes to github.com

Skip to content

non_negative_factorization's 'regularize' parameter is lost in the OO interface #12520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sebastiantiesmeyer opened this issue Nov 5, 2018 · 5 comments · Fixed by #17414
Closed

non_negative_factorization's 'regularize' parameter is lost in the OO interface #12520

sebastiantiesmeyer opened this issue Nov 5, 2018 · 5 comments · Fixed by #17414
Labels
Easy Well-defined and straightforward way to resolve Enhancement good first issue Easy with clear instructions to resolve

Comments

@sebastiantiesmeyer
Copy link

Description

The function 'non_negative_factorization' in decomposition/nmf.py has a nice parameter 'regularization' where the regularization can be specified towards one of the product factors. There is however no way to access this feature when using an NMF object. Could be solved easily by carrying over the parameter to the constructor of the NMF object and creating a field 'self.regularize'.
@konqr
Copy link

konqr commented Dec 20, 2018

Can I pick this up?

@adrinjalali
Copy link
Member

From what I see in the code it seems like a reasonable fix; but I may be wrong. @konqr you can give it a shot, and I guess we'll see in the PR if it's reasonable to use those different options. Please bare in mind that you'll need to add some tests as well. It's interesting that currently only regularization='both' is covered in our tests of the function.

@konqr
Copy link

konqr commented Dec 21, 2018

Thanks @adrinjalali. I'll give it a shot.

@amueller amueller added Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted labels May 29, 2020
@bharatr21 bharatr21 mentioned this issue Jun 1, 2020
Merged
@JosephTLucas
Copy link
Contributor

I'd like to do this for the June 6th Sprint. Is it already solved with PR 17414?

@thomasjpfan
Copy link
Member

Yes is it being worked on at #17414

@cmarmo cmarmo removed the help wanted label Jun 6, 2020
@amueller amueller mentioned this issue Jun 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve Enhancement good first issue Easy with clear instructions to resolve
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Add regularization to the main NMF class
7 participants
@amueller @cmarmo @adrinjalali @thomasjpfan @JosephTLucas @konqr @sebastiantiesmeyer