Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RANSAC does not pass sample weights to final estimator #13425

Closed
@gerhajdu

Description

@gerhajdu

RANSACRegressor does not pass weights to the used estimator during the training of the final model.

Sample weights to RANSAC have been requested by #5871 and #6113, and implemented in #6140, but the weights of the final inlier sample are not used during the training of the final model.

The issue only causes crashes when using a custom estimator which always requires the sample_weight parameter to be passed to it, as is the case in the training of the final estimator with the current implementation.

# estimate final model using all inliers
base_estimator.fit(X_inlier_best, y_inlier_best)
self.estimator_ = base_estimator

Metadata

Metadata

Assignees

No one assigned

    Labels

    EasyWell-defined and straightforward way to resolvehelp wanted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions