Sample property routing from #9566 with added support for routing to transform, scorers, prediction functions - #15425
Closed
hermidalc wants to merge 2 commits into
Closed
Conversation
Contributor
|
Thanks @hermidalc for your pull request. |
Member
|
Thanks for the prototype @hermidalc , I think we're leaning towards solution 4 of the SLEP, currently being implemented in #16079 . As I understand, we almost have a consensus that it'd be a better solution. |
Member
|
We can close this PR since the |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This is relevant to SLEP006. I took code from #9566 and merged it with my code to also support routing to transform, scorers, and prediction functions within
Pipelineand*SearchCV.I also added my own hack to get feature properties routing and subsetting to work within
Pipelineand*SearchCV. It's a hack because the only solution I could currently see is to fix in the source code what the name of the feature properties kwarg is, but I needed it now for my own work...Any other comments?
This is intended to be exploratory to see what can work and how designs look when implemented.