Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Python 3.8 CI #15618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rth opened this issue Nov 13, 2019 · 4 comments · Fixed by #15637
Closed

Add Python 3.8 CI #15618

rth opened this issue Nov 13, 2019 · 4 comments · Fixed by #15637
Labels
Build / CI
Milestone
0.22

Comments

@rth
Copy link
Member

rth commented Nov 13, 2019 •
edited
Loading

It would be good add an explicit CI for python 3.8

python 3.8 is on conda (default and conda-forge), also numpy, scipy and pandas have python 3.8 wheels.

I though that pylatest_conda_mkl (Azure) might be taking the latest python on conda, but it doesn't seem to be the case.

The issue for building corresponding wheels is MacPython/scikit-learn-wheels#34
@rth rth added the Build / CI label Nov 13, 2019
@rth rth added this to the 0.22 milestone Nov 13, 2019
@adrinjalali
Copy link
Member

IIRC, I think we stopped the pylatest_conda_mkl from getting 3.8 cause it was trying to compile scipy.

We can add a 3.8 to the CI now.

But I think for the RC, we don't need this, we can release, and add the 3.8 wheels for the release, or for 0.22.1

@gaborbernat
Copy link

Can we get a python3.8 wheel here? :-)

@amueller
Copy link
Member

I think it might be good to add 3.8 wheels and conda packages to the RC. That's a pretty important thing to test in an RC.

@amueller
Copy link
Member

@thomasjpfan can you maybe look into adding it to azure?

@amueller amueller mentioned this issue Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
0.22
Development

Successfully merging a pull request may close this issue.

MAINT run latest CI on Python 3.8 amueller/scikit-learn
4 participants
@amueller @rth @gaborbernat @adrinjalali