Thanks to visit codestin.com
Credit goes to github.com

Skip to content

RandomTreesEmbedding has a max_samples parameter but no bootstrap #15670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MDouriez opened this issue Nov 20, 2019 · 1 comment · Fixed by #15693
Closed

RandomTreesEmbedding has a max_samples parameter but no bootstrap #15670

MDouriez opened this issue Nov 20, 2019 · 1 comment · Fixed by #15693
Labels
Bug
Milestone
0.22

Comments

@MDouriez
Copy link
Contributor

MDouriez commented Nov 20, 2019 •
edited
Loading

Description

In the __init__, bootstrap is set to False: https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/ensemble/_forest.py#L2174. Looks like max_samples is never used?

Steps/Code to Reproduce

Expected Results

Actual Results

Versions
@MDouriez MDouriez mentioned this issue Nov 20, 2019
Merged
@glemaitre
Copy link
Member

Yes, this seems correct. It seems that he parameter should not have been added in the docstring and let it to None.

@glemaitre glemaitre added the Bug label Nov 21, 2019
@glemaitre glemaitre added this to the 0.22 milestone Nov 21, 2019
@glemaitre glemaitre mentioned this issue Nov 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.22
Development

Successfully merging a pull request may close this issue.

FIX remove max_samples in RandomTreesEmbedding glemaitre/scikit-learn
2 participants
@glemaitre @MDouriez