Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DPGMM - _update_concentrations fail implementation] #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tamnguyenthe opened this issue Mar 12, 2013 · 2 comments
Closed

[DPGMM - _update_concentrations fail implementation] #1764

tamnguyenthe opened this issue Mar 12, 2013 · 2 comments
Labels
Bug
Milestone
0.18

Comments

@tamnguyenthe
Copy link

in method update_concentration, DPGMM
i think it should be:
self.gamma[i, 2] = self.gamma_[i + 1, 2] + sz[i+1]
instead of:
self.gamma_[i, 2] = self.gamma_[i + 1, 2] + sz[i]
@amueller amueller added this to the 0.15.1 milestone Jul 18, 2014
@amueller
Copy link
Member

I agree. Maybe @alextp can confirm. Otherwise sz[self.n_components] is not included in the sum.
Maybe we should write

self.gamma_[:-1, 2] = np.cumsum(sz[::-1])[::-1][1:]

but that is also not super readable.

@amueller amueller mentioned this issue Jan 28, 2015
Closed
@amueller amueller modified the milestones: 0.16, 0.17 Sep 11, 2015
@amueller amueller modified the milestones: 0.18, 0.17 Sep 20, 2015
@tguillemot tguillemot mentioned this issue Sep 2, 2016
Closed
@ogrisel
Copy link
Member

ogrisel commented Sep 10, 2016

Closing: the new Dirichlet process GMM re-write has been merged in master.

@ogrisel ogrisel closed this as completed Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.18
3 participants
@ogrisel @amueller @tamnguyenthe