Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add Lasso regularization to PoissonRegressor #22289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ebatty opened this issue Jan 24, 2022 · 7 comments
Closed

Add Lasso regularization to PoissonRegressor #22289

ebatty opened this issue Jan 24, 2022 · 7 comments

Comments

@ebatty
Copy link

ebatty commented Jan 24, 2022

Describe the workflow you want to enable

Linear and logistic regression allow l1, l2, or elasticnet regularization. However, the Poisson regression class (which is amazing to have!) only allows L2 regularization.

Describe your proposed solution

Enable flexible regularization choices for the Generalized Linear Models

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@ebatty ebatty added Needs Triage Issue requires triage New Feature labels Jan 24, 2022
@vmodi1
Copy link

vmodi1 commented Jan 27, 2022

Hey @ebatty, I would like to contribute to this issue. It would be my first contribution. Can you assign this to me?

@thomasjpfan
Copy link
Member

@Vandinimodi1595 This is likely not a good first issue. One needs to be familiar with scikit-learn's workflow and requirements for adding a new feature, which involves updates to the user guide, tests, examples & implementation. To learn about scikit-learn's workflow, a good first issue is #21350

@lorentzenchr As for inclusion, what do you think about adding other types of regularization into the GLMs?

@thomasjpfan thomasjpfan removed the Needs Triage Issue requires triage label Jan 27, 2022
@vmodi1
Copy link

vmodi1 commented Jan 27, 2022

@thomasjpfan, Could you assign that issue #21350 for me then?

@thomasjpfan
Copy link
Member

thomasjpfan commented Jan 27, 2022

Could you assign that issue #21350 for me then?

That issue can not be assigned to a single person because it is a list of 229 items around the same issue. There has already been around ~ 30 people that worked on the issue. As of this writing, there is still a 170 items to go. You can read the issue to see how to begin working on it.

@vmodi1
Copy link

vmodi1 commented Jan 27, 2022

Thank you @thomasjpfan, I will look into it.

@lorentzenchr
Copy link
Member

This is a duplicate of #16637 and definitely on my longer roadmap. #21808 is an important step in that direction as it will enable to compute Hessians for linear models, which will enable 2nd order coordinates descent, like glmnet.
@ebatty Thanks for your feedback on the PoissonRegeessor and opening this issue.

@eduardosand
Copy link

eduardosand commented Apr 16, 2025

Looking at this now, I don't see the ability currently to use lasso or elastic net as valid regularization schemes in the PoissonRegressor class. Should this issue be reopened, since it hasn't been resolved? @lorentzenchr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants