You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Furthermore, some variable selection strategies assume that your estimator has this attribute, and it seems suboptimal to me to deprive ourselves of using HistGradientBoosting with these techniques.
but I believe we have more points in favor of its implementation than its omission. I'd love to hear your thoughts. :)
I don't think that we should implement the feature. Indeed, there is not a single variable/feature importance that rules them all and I think that we should not have a single attribute.
Right now, our API of the SelectFromModel is a bit limited: we accept a callable. However, it takes only a fitted estimator as an attribute. So you could still do something ugly as:
I think it could useful to find a way to compute the mean decrease in impurity (MDI) but the feature_importances_ API is too limiting because it forces us to only consider training set statistics.
So let's find a way to implement/fix #20059 in general (and in particular how to compute MDI on test data #20059 (comment)) and then we can discuss how to make this available for HistGradientBoosting* models.
Describe the workflow you want to enable
The practicality of using the
.feature_importances_
attribute to superficially analyze global explanations of your classifier is really useful, IMHO.Right after evaluating the model, running something like
is the first thing I do.
Furthermore, some variable selection strategies assume that your estimator has this attribute, and it seems suboptimal to me to deprive ourselves of using
HistGradientBoosting
with these techniques.I understand the concerns raised by @ogrisel's comment in the original PR that implemented HistGradientBoosting, but I believe we have more points in favor of its implementation than its omission. I'd love to hear your thoughts. :)
Describe your proposed solution
No response
Describe alternatives you've considered, if relevant
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: