Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reduce ninja's verbosity from subprocesses #28758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeremiedbb opened this issue Apr 3, 2024 · 2 comments
Closed

Reduce ninja's verbosity from subprocesses #28758

jeremiedbb opened this issue Apr 3, 2024 · 2 comments
Labels
Needs Triage Issue requires triage

Comments

@jeremiedbb
Copy link
Member

When importing scikit-learn, even if there's nothing to recompile, ninja will output

+ /home/jeremie/miniforge/envs/dev/bin/ninja
ninja: no work to do.

This is acceptable, but when using an estimator that uses multiprocessing, it will be printed for each sub-process which can be a bit annoying (and mixed with the prints of said estimator)
@github-actions github-actions bot added the Needs Triage Issue requires triage label Apr 3, 2024
@lesteve
Copy link
Member

lesteve commented Apr 4, 2024 •
edited
Loading

Yep, this is mesonbuild/meson-python#594 😉. Hopefully this will be merged soonish and a new meson-python will be made (it also has mesonbuild/meson-python#569 that we care about, this is the reason we are using pytest<8 in the CI). My understanding is that Ralf Gommers is the only possible reviewer and that with Numpy 2.0 migration he has other priorities, which is completetely understandable.

Note you can build without verbose if you are too annoyed (remove the flag in the pip install command), there is also an environment variable you can use MESONPY_EDITABLE_VERBOSE https://meson-python.readthedocs.io/en/latest/how-to-guides/editable-installs.html#verbose-mode. I am not sure which one takes precedence to be honest.

Closing this one, because the problem will likely be fixed in the not so distant future 🤞.

@lesteve lesteve closed this as completed Apr 4, 2024
@lesteve
Copy link
Member

lesteve commented Apr 18, 2024

meson-python 0.16 has been released on April 16 and fixes this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Triage Issue requires triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lesteve @jeremiedbb