Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add multi-output support to the bagging module #3449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arjoly opened this issue Jul 20, 2014 · 9 comments
Closed

Add multi-output support to the bagging module #3449

arjoly opened this issue Jul 20, 2014 · 9 comments

Comments

@arjoly
Copy link
Member

arjoly commented Jul 20, 2014

This would nice to add multi-output support to bagging as in the sklearn.ensemble.forest module. Some code could be refactored.

@arjoly arjoly changed the title Add multi-output support to bagging Add multi-output support to the bagging module Jul 20, 2014
@ldirer
Copy link
Contributor

ldirer commented Jul 20, 2014

I'll try to work on this one.

@arjoly
Copy link
Member Author

arjoly commented Jul 20, 2014

Thanks @ldirer

@tliu30
Copy link

tliu30 commented Sep 27, 2014

Is this issue still open? If not, I'd like to pick it up!

@ldirer
Copy link
Contributor

ldirer commented Sep 27, 2014

I haven't really worked on it so you are welcome to pick it up if you want!

@arjoly
Copy link
Member Author

arjoly commented Sep 29, 2014

You might want to have a look at the forest code from 0.14 which is similar to what should be done in the multi-output setting.

https://github.com/scikit-learn/scikit-learn/blob/0.14.X/sklearn/ensemble/forest.py

@tliu30
Copy link

tliu30 commented Sep 30, 2014

Yup! I've been cribbing a good amount from the forest.py code.

I think everything is just about done, but I do have a quick question: is there a notion of a "decision function" in a multi-output setting? I did a quick look and all the estimators implementing a decision_function method seem to only have single-dim outputs.

@arjoly
Copy link
Member Author

arjoly commented Sep 30, 2014

With multi-output data, I would go with a list of arrays. One array for each output.

@tliu30
Copy link

tliu30 commented Oct 23, 2014

Okay - I've submitted a pull request #3798

@adrinjalali
Copy link
Member

implemented in #9707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants