Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sklearn.cluster.DBSCAN: Allow for 'nan' values for user-defined metric #4283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
denniskl opened this issue Feb 23, 2015 · 2 comments
Closed

sklearn.cluster.DBSCAN: Allow for 'nan' values for user-defined metric #4283

denniskl opened this issue Feb 23, 2015 · 2 comments
Labels
Enhancement help wanted module:cluster

Comments

@denniskl
Copy link 

import sklearn

def user_defined_metric(u, v):
    ...

cluster_algorithm = sklearn.cluster.DBSCAN(metric=user_defined_metric)
cluster_algorithm.fit(matrix)
...

does not work if matrix contains numpy.nan values. However, the user-defined metric might be able to handle nan values.

Would be great if you could allow nan values if a user-defined metric is defined.
@amueller
Copy link
Member

Yeah we should do less strict input validation with user defined metrics. PR welcome.

@raghavrv raghavrv mentioned this issue Feb 24, 2015
Closed
@amueller amueller mentioned this issue Oct 26, 2018
Closed
@adrinjalali
Copy link
Member

I think #10482 has fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement help wanted module:cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Allow nan for userdefined metric in dbscan et al raghavrv/scikit-learn
4 participants
@amueller @cmarmo @adrinjalali @denniskl