-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
Fixing incoherent style of references #4344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Minor suggestion : We could have a script (not a test) that could scrape the reference links and verify them all... The script could be run before every release maybe? |
The problem with having sphinx referencable references is that sphinx will complain if there are duplicates. On the other hand, we definitely want to list references in multiple docstrings. +1 on the general theme though. |
@ragv I aggree, one could write a script like that. @amueller I didn't know that sphinx complains about duplicates. One could use what should be used for referencing: bibtex. There is sphinxcontrib-bibtex which integrates bibtex into sphinx. However, having a sep. bibtex file also makes the docstring a bit harder to read. And there is another dependency. |
Yeah -1 on bibtex. Why is the benefit of having a referenceable reference in the docstring? I think a list would be just fine. |
Referenceable reference are nice because you can say things like: "...we did X according to [ref1] and Y according to [ref2]..." ( exmaple) Alternatively, when only using lists for the references one could just put the name of the first author + year (or something similar) into the brakets. |
That would be kind of nice, if the docstrings where that detailed ;) |
So we could use that & a script that checks the if the links to the pdf are alive. Edit: |
I'd suggest settling for the following:
This is also how scipy does it...most of the time. See http://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.minimize.html#id12 |
Checking links with sphinx: Maybe there is no need for an extenal scirpt. Haven't tried it yet. |
There are currently 139 non-local redirects and broken links in the docs. |
Thats awesome! Hey btw do we need to decide on the order of the papers? (chronological / relevance / alphabetical / simply leave the order as it is) |
is there a simple command line way to check the links of the doc? or maybe |
Oh, sorry. This is how you do it:
This however currently builds all the docs including plots. But in the end you get the file |
excellent thanks !
|
if the numeric style doesn't give any warnings, I'm all for it. |
@sotte hey :) any news on this? :) |
@ragv I've been very busy but I'll try to finish it this weekend... |
We've standardized our docstrings a lot ever since. |
TLDR: The references in the docstrings have weird/wrong/very different formats. "There should be one-- and preferably only one --obvious way to do it."
I was looking at the reference links of some classifiers when I realized they were not formated correctly. When I was about to submit a pull request I realized that many references have a different format and according to the Zen of Python
Some references
I think references should be referencable, be as concise as possible (authors, title, conference/book, etc). I'm not sure about the link to the PDFs because the URIs change over time and lead to dead links. What do you think?
My suggestion:
I'd be willing to spend a few hours on the weekend to fix the references once we decide on how it's supposed to look like.
Also, #3912 should document the format for the references.
The text was updated successfully, but these errors were encountered: