Thanks to visit codestin.com
Credit goes to github.com

Skip to content

metrics.mutual_info_score hangs when given real vectors #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
poldrack opened this issue Jul 14, 2015 · 6 comments
Closed

metrics.mutual_info_score hangs when given real vectors #4976

poldrack opened this issue Jul 14, 2015 · 6 comments
Labels
Bug Easy Well-defined and straightforward way to resolve

Comments

@poldrack
Copy link

I accidentally passed two real vectors to this function, and it ended up completely hanging my mac, requiring several hard reboots until I discovered the issue (version 0.16.1, mac os x 10.10). Should probably validate the inputs to prevent this.

@amueller amueller added the Bug label Jul 30, 2015
@amueller
Copy link
Member

I agree. We should actually do this for clustering and classification metrics and also for all classifiers using type_or_target.

@amueller
Copy link
Member

See also #5060

@amueller amueller added Easy Well-defined and straightforward way to resolve Need Contributor labels Jul 30, 2015
@amueller
Copy link
Member

Fixing this occurrence is pretty easy, but I think we should fix it "once and for all".
For the metrics there are also common tests, where we should check this.

@jayflo
Copy link

jayflo commented Aug 5, 2015

If this is not included in the fixes for #5084, I will take a look after the pull requests are merged.

@tomMoral
Copy link
Contributor

I will look into it today.

@GaelVaroquaux
Copy link
Member

Fixed by #5445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy Well-defined and straightforward way to resolve
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants