-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
metrics.mutual_info_score hangs when given real vectors #4976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree. We should actually do this for clustering and classification metrics and also for all classifiers using |
See also #5060 |
Fixing this occurrence is pretty easy, but I think we should fix it "once and for all". |
If this is not included in the fixes for #5084, I will take a look after the pull requests are merged. |
I will look into it today. |
Fixed by #5445 |
I accidentally passed two real vectors to this function, and it ended up completely hanging my mac, requiring several hard reboots until I discovered the issue (version 0.16.1, mac os x 10.10). Should probably validate the inputs to prevent this.
The text was updated successfully, but these errors were encountered: