Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Why does the "releases" link in the readme point to sourceforge? #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nelson-liu opened this issue Mar 10, 2016 · 7 comments · Fixed by #7637
Closed

Why does the "releases" link in the readme point to sourceforge? #6515

nelson-liu opened this issue Mar 10, 2016 · 7 comments · Fixed by #7637

Comments

@nelson-liu
Copy link
Contributor

In the readme, the link for "releases" points to https://sourceforge.net/projects/scikit-learn/files/. It doesn't seem to be updated for 17.1, and I find it a bit odd since we also have releases on github here: https://github.com/scikit-learn/scikit-learn/releases.

Additionally, sourceforge has a pretty shady history of bundling malware with downloads. See https://notepad-plus-plus.org/news/notepad-plus-plus-leaves-sf.html.

Is there a reason that the readme links to sourceforge, or have we switched over to github? If its the latter case, I'd be happy to open a PR to amend the error.
@GaelVaroquaux
Copy link
Member

If I recall correctly, the only thing that we still need sourceforge for
is the PDF documentation, which we don't update at each release because
it is very fragile.

The right place to link too would be pypi:
https://pypi.python.org/pypi/scikit-learn

@nelson-liu
Copy link
Contributor Author

closing because question answered, thanks gael.

@amueller
Copy link
Member

We actually do update the PDF documentation, and we have unit tests to ensure that it doesn't break IIRC. So I don't think we need sourceforge any more.

@amueller
Copy link
Member

only that the links to the pdf docs are dead. Pretty sure I fixed that for the last release....

@nelson-liu
Copy link
Contributor Author

@amueller in that case, should i raise a quick pr to change the releases link to pypi?

@amueller
Copy link
Member

@nelson-liu please :)

@nelson-liu nelson-liu reopened this Oct 11, 2016
@nelson-liu nelson-liu mentioned this issue Oct 11, 2016
Merged
@nelson-liu
Copy link
Contributor Author

@amueller sure, see #7637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] edit releases link from sf to pypi nelson-liu/scikit-learn
3 participants
@GaelVaroquaux @amueller @nelson-liu