Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[DOC] MultiTaskLasso : coef_ transpose? #8472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josephsalmon opened this issue Feb 28, 2017 · 0 comments · Fixed by #8473
Closed

[DOC] MultiTaskLasso : coef_ transpose? #8472

josephsalmon opened this issue Feb 28, 2017 · 0 comments · Fixed by #8473

Comments

@josephsalmon
Copy link
Contributor

Description

I believe there is an issue with the coef_ description. The method is presented as :
(1 / (2 * n_samples)) * ||Y - XW||^2_Fro + alpha * ||W||_21
but coef_ returns W.T, currently : W.shape= [n_features,n_tasks] but coef_.shape=[n_tasks,n_features], cf. coordinate_descent.py--L1612

Why not outputting W directly? Instead of transposing the output, at least the doc should be consistent with the current implementation.
I am sending a PR for the second solution.

@agramfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant