Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pull request instructions not up to date in dev docs. #8530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Mar 4, 2017 · 2 comments · Fixed by #8538
Closed

pull request instructions not up to date in dev docs. #8530

amueller opened this issue Mar 4, 2017 · 2 comments · Fixed by #8538
Labels
Documentation Easy Well-defined and straightforward way to resolve Sprint

Comments

@amueller
Copy link
Member

amueller commented Mar 4, 2017

I think the dev docs should describe the "quick way" to do a pull request by going on the main repo and clicking the automatically appearing button, maybe adding a screenshot.

We could also add screenshots for the forking maybe?
@amueller amueller added Documentation Easy Well-defined and straightforward way to resolve Need Contributor Sprint labels Mar 4, 2017
@tfolkman
Copy link
Contributor

tfolkman commented Mar 5, 2017

Hey - I am looking to contribute more back and this looks like a good place to start. So I can take this.

I assume you are referring to the "CONTRIBUTING.md?" Also, GitHub has good docs on how to make a pull request from a fork (https://help.github.com/articles/creating-a-pull-request-from-a-fork/) and forking a repo (https://help.github.com/articles/fork-a-repo/). Would it makes sense to just reference these? Thanks!

@jnothman
Copy link
Member

jnothman commented Mar 5, 2017 via email

tfolkman added a commit to tfolkman/scikit-learn that referenced this issue Mar 5, 2017
@tfolkman
DOC More detailed pull request and fork instructions (scikit-learn#8530)
49b686c
@tfolkman tfolkman mentioned this issue Mar 6, 2017
Merged
tfolkman added a commit to tfolkman/scikit-learn that referenced this issue Mar 6, 2017
@tfolkman
DOC More detailed pull request and fork instructions (scikit-learn#8530)
360c8b5
tfolkman added a commit to tfolkman/scikit-learn that referenced this issue Mar 6, 2017
@tfolkman
DOC More detailed pull request and fork instructions (scikit-learn#8530)
bf2ab4f
lesteve pushed a commit that referenced this issue Mar 7, 2017
@tfolkman @lesteve
[MRG] DOC More detailed pull request and fork instructions (#8530) (#…
618f8d2 
…8538)
@Przemo10 Przemo10 mentioned this issue Mar 17, 2017
Closed
herilalaina pushed a commit to herilalaina/scikit-learn that referenced this issue Mar 26, 2017
@tfolkman @herilalaina
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
7de41c2 
…arn#8530) (scikit-learn#8538)
massich pushed a commit to massich/scikit-learn that referenced this issue Apr 26, 2017
@tfolkman
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
a4fd554 
…arn#8530) (scikit-learn#8538)
Sundrique pushed a commit to Sundrique/scikit-learn that referenced this issue Jun 14, 2017
@tfolkman @Sundrique
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
df962e1 
…arn#8530) (scikit-learn#8538)
NelleV pushed a commit to NelleV/scikit-learn that referenced this issue Aug 11, 2017
@tfolkman @NelleV
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
7ee99e4 
…arn#8530) (scikit-learn#8538)
paulha pushed a commit to paulha/scikit-learn that referenced this issue Aug 19, 2017
@tfolkman @paulha
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
74888bd 
…arn#8530) (scikit-learn#8538)
maskani-moh pushed a commit to maskani-moh/scikit-learn that referenced this issue Nov 15, 2017
@tfolkman @maskani-moh
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
4c3396b 
…arn#8530) (scikit-learn#8538)
jwjohnson314 pushed a commit to jwjohnson314/scikit-learn that referenced this issue Dec 18, 2017
@tfolkman
[MRG] DOC More detailed pull request and fork instructions (scikit-le…
0b6d32b 
…arn#8530) (scikit-learn#8538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Easy Well-defined and straightforward way to resolve Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] DOC More detailed pull request and fork instructions (#8530) tfolkman/scikit-learn
3 participants
@jnothman @amueller @tfolkman