Thanks to visit codestin.com
Credit goes to github.com

DecisionTreeRegressor and DecisionTreeClassifier document lack the explanation of parameter min_impurity_split #8903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

qinhanmin2014 opened this issue May 19, 2017 · 1 comment · Fixed by #8907

Member

qinhanmin2014 commented May 19, 2017

In the latest version of the document(http://scikit-learn.org/dev/modules/generated/sklearn.tree.DecisionTreeClassifier.html#sklearn.tree.DecisionTreeClassifier), there isn't any explanation of parameter min_impurity_split in DecisionTreeRegressor and DecisionTreeClassifier, which still exists in the current version. In the previous version(http://scikit-learn.org/stable/modules/generated/sklearn.tree.DecisionTreeClassifier.html#sklearn.tree.DecisionTreeClassifier), there are relevant explanations of the parameter. Should we explain it in the latest version like the previous version? If so, I'm willing to help. Thanks.

The text was updated successfully, but these errors were encountered:

Member

glemaitre commented May 19, 2017 •

edited

Loading

~~I think it should be added back and mentioned that the parameter has been deprecated:~~

NOTE: `min_impurity_split` is deprecated from 0.19 and will be removed in 0.21 Use `min_impurity_decrease` instead.

Edit:

It seems that we just delete the parameter from the docstring when he got deprecated without note.
Refer to #8278 (review) for an example

Refer to #8904

glemaitre mentioned this issue

[MRG] DOC Homogeneous deprecation in docstring #8907

Merged

lesteve closed this as completed in #8907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment