From f118b7663c7af8a1c2fc5ad59662aee39a907927 Mon Sep 17 00:00:00 2001 From: Rohan Varma Date: Mon, 8 Oct 2018 00:44:52 -0700 Subject: [PATCH 1/2] rm criterion and max_features from __init__ and store them as class attrs instead --- sklearn/ensemble/forest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sklearn/ensemble/forest.py b/sklearn/ensemble/forest.py index 0805e835933cc..2dcd2ad514eee 100644 --- a/sklearn/ensemble/forest.py +++ b/sklearn/ensemble/forest.py @@ -1766,6 +1766,8 @@ def __init__(self, class RandomTreesEmbedding(BaseForest): + criterion = 'mse' + max_features = 1 """An ensemble of totally random trees. An unsupervised transformation of a dataset to a high-dimensional @@ -1925,12 +1927,10 @@ def __init__(self, verbose=verbose, warm_start=warm_start) - self.criterion = 'mse' self.max_depth = max_depth self.min_samples_split = min_samples_split self.min_samples_leaf = min_samples_leaf self.min_weight_fraction_leaf = min_weight_fraction_leaf - self.max_features = 1 self.max_leaf_nodes = max_leaf_nodes self.min_impurity_decrease = min_impurity_decrease self.min_impurity_split = min_impurity_split From d1b67dc0b1a2c151b6d378d125c625c951866a97 Mon Sep 17 00:00:00 2001 From: Rohan Varma Date: Mon, 8 Oct 2018 13:22:55 -0700 Subject: [PATCH 2/2] make sure that the docstring comes first --- sklearn/ensemble/forest.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sklearn/ensemble/forest.py b/sklearn/ensemble/forest.py index 2dcd2ad514eee..6c3bb93e2c071 100644 --- a/sklearn/ensemble/forest.py +++ b/sklearn/ensemble/forest.py @@ -1766,8 +1766,6 @@ def __init__(self, class RandomTreesEmbedding(BaseForest): - criterion = 'mse' - max_features = 1 """An ensemble of totally random trees. An unsupervised transformation of a dataset to a high-dimensional @@ -1898,6 +1896,9 @@ class RandomTreesEmbedding(BaseForest): """ + criterion = 'mse' + max_features = 1 + def __init__(self, n_estimators='warn', max_depth=5,