From 2052aeabe469042cb171e4ae4eca103e5c7a1849 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Est=C3=A8ve?= Date: Tue, 28 Jun 2022 09:24:31 +0200 Subject: [PATCH 1/2] MNT make linkcheck run without errors --- doc/about.rst | 2 +- doc/conf.py | 12 ++++++++---- doc/modules/decomposition.rst | 2 +- doc/modules/semi_supervised.rst | 2 +- sklearn/cluster/_spectral.py | 6 +++--- sklearn/cross_decomposition/_pls.py | 2 +- sklearn/decomposition/_kernel_pca.py | 4 ++-- 7 files changed, 17 insertions(+), 13 deletions(-) diff --git a/doc/about.rst b/doc/about.rst index 5018c5baec761..2496c1afa0ed3 100644 --- a/doc/about.rst +++ b/doc/about.rst @@ -423,7 +423,7 @@ time of Joris van den Bossche (2017-2018). .. image:: images/cds-logo.png :width: 100pt :align: center - :target: https://www.datascience-paris-saclay.fr/ + :target: http://www.datascience-paris-saclay.fr/ .. raw:: html diff --git a/doc/conf.py b/doc/conf.py index b4c944a928c3c..799ce4b74dd5c 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -598,15 +598,19 @@ def setup(app): # links falsely flagged as broken "https://www.researchgate.net/publication/" "233096619_A_Dendrite_Method_for_Cluster_Analysis", - "https://www.researchgate.net/publication/" - "221114584_Random_Fourier_Approximations_" + "https://www.researchgate.net/publication/221114584_Random_Fourier_Approximations_" "for_Skewed_Multiplicative_Histogram_Kernels", + "https://www.researchgate.net/publication/4974606_" + "Hedonic_housing_prices_and_the_demand_for_clean_air", + "https://www.researchgate.net/profile/Anh-Huy-Phan/publication/220241471_Fast_" + "Local_Algorithms_for_Large_Scale_Nonnegative_Matrix_and_Tensor_Factorizations", "https://doi.org/10.13140/RG.2.2.35280.02565", "https://www.microsoft.com/en-us/research/uploads/prod/2006/01/" "Bishop-Pattern-Recognition-and-Machine-Learning-2006.pdf", - "https://www.researchgate.net/publication/4974606_" - "Hedonic_housing_prices_and_the_demand_for_clean_air", + "https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/tr-99-87.pdf", + "https://microsoft.com/", "https://www.jstor.org/stable/2984099", + "https://stat.uw.edu/sites/default/files/files/reports/2000/tr371.pdf", # Broken links from testimonials "http://www.bestofmedia.com", "http://www.data-publica.com/", diff --git a/doc/modules/decomposition.rst b/doc/modules/decomposition.rst index 540fb22006dd8..54f95414df8b2 100644 --- a/doc/modules/decomposition.rst +++ b/doc/modules/decomposition.rst @@ -956,7 +956,7 @@ is not readily available from the start, or when the data does not fit into memo .. [4] `"SVD based initialization: A head start for nonnegative matrix factorization" - `_ + `_ C. Boutsidis, E. Gallopoulos, 2008 .. [5] `"Fast local algorithms for large scale nonnegative matrix and tensor diff --git a/doc/modules/semi_supervised.rst b/doc/modules/semi_supervised.rst index 249c6f98a7976..f5c732d9024cb 100644 --- a/doc/modules/semi_supervised.rst +++ b/doc/modules/semi_supervised.rst @@ -148,4 +148,4 @@ which can drastically reduce running times. [3] Olivier Delalleau, Yoshua Bengio, Nicolas Le Roux. Efficient Non-Parametric Function Induction in Semi-Supervised Learning. AISTAT 2005 - https://research.microsoft.com/en-us/people/nicolasl/efficient_ssl.pdf + http://www.gatsby.ucl.ac.uk/aistats/fullpapers/204.pdf diff --git a/sklearn/cluster/_spectral.py b/sklearn/cluster/_spectral.py index 28989665dfed2..7a68df3a077a6 100644 --- a/sklearn/cluster/_spectral.py +++ b/sklearn/cluster/_spectral.py @@ -589,11 +589,11 @@ class SpectralClustering(ClusterMixin, BaseEstimator): Stella X. Yu, Jianbo Shi `_ - .. [4] `Toward the Optimal Preconditioned Eigensolver: - Locally Optimal Block Preconditioned Conjugate Gradient Method, 2001. + .. [4] :doi:`Toward the Optimal Preconditioned Eigensolver: + Locally Optimal Block Preconditioned Conjugate Gradient Method, 2001 A. V. Knyazev SIAM Journal on Scientific Computing 23, no. 2, pp. 517-541. - `_ + <10.1137/S1064827500366124>` .. [5] :doi:`Simple, direct, and efficient multi-way spectral clustering, 2019 Anil Damle, Victor Minden, Lexing Ying diff --git a/sklearn/cross_decomposition/_pls.py b/sklearn/cross_decomposition/_pls.py index 8a804142e13bb..bceb0c47c21ba 100644 --- a/sklearn/cross_decomposition/_pls.py +++ b/sklearn/cross_decomposition/_pls.py @@ -170,7 +170,7 @@ class _PLS( Main ref: Wegelin, a survey of Partial Least Squares (PLS) methods, with emphasis on the two-block case - https://www.stat.washington.edu/research/reports/2000/tr371.pdf + https://stat.uw.edu/sites/default/files/files/reports/2000/tr371.pdf """ @abstractmethod diff --git a/sklearn/decomposition/_kernel_pca.py b/sklearn/decomposition/_kernel_pca.py index 9f8f551b6628a..9f598c3eba670 100644 --- a/sklearn/decomposition/_kernel_pca.py +++ b/sklearn/decomposition/_kernel_pca.py @@ -216,7 +216,7 @@ class KernelPCA(_ClassNamePrefixFeaturesOutMixin, TransformerMixin, BaseEstimato .. [2] `Bakır, Gökhan H., Jason Weston, and Bernhard Schölkopf. "Learning to find pre-images." Advances in neural information processing systems 16 (2004): 449-456. - `_ + `_ .. [3] :arxiv:`Halko, Nathan, Per-Gunnar Martinsson, and Joel A. Tropp. "Finding structure with randomness: Probabilistic algorithms for @@ -532,7 +532,7 @@ def inverse_transform(self, X): `Bakır, Gökhan H., Jason Weston, and Bernhard Schölkopf. "Learning to find pre-images." Advances in neural information processing systems 16 (2004): 449-456. - `_ + `_ """ if not self.fit_inverse_transform: raise NotFittedError( From b1824b8137e16c7d64e0b8acd44a40e42e7fb60c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Est=C3=A8ve?= Date: Tue, 28 Jun 2022 10:34:35 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Olivier Grisel --- doc/modules/decomposition.rst | 2 +- doc/modules/semi_supervised.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/modules/decomposition.rst b/doc/modules/decomposition.rst index 54f95414df8b2..293f31dacd091 100644 --- a/doc/modules/decomposition.rst +++ b/doc/modules/decomposition.rst @@ -956,7 +956,7 @@ is not readily available from the start, or when the data does not fit into memo .. [4] `"SVD based initialization: A head start for nonnegative matrix factorization" - `_ + `_ C. Boutsidis, E. Gallopoulos, 2008 .. [5] `"Fast local algorithms for large scale nonnegative matrix and tensor diff --git a/doc/modules/semi_supervised.rst b/doc/modules/semi_supervised.rst index f5c732d9024cb..47e8bfffdd9a7 100644 --- a/doc/modules/semi_supervised.rst +++ b/doc/modules/semi_supervised.rst @@ -148,4 +148,4 @@ which can drastically reduce running times. [3] Olivier Delalleau, Yoshua Bengio, Nicolas Le Roux. Efficient Non-Parametric Function Induction in Semi-Supervised Learning. AISTAT 2005 - http://www.gatsby.ucl.ac.uk/aistats/fullpapers/204.pdf + https://www.gatsby.ucl.ac.uk/aistats/fullpapers/204.pdf