From 8de5bd65100e6d8d994ab88c2f38ee89e0f8806f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Th=C3=A9ophile=20Baranger?= Date: Mon, 27 Mar 2023 22:39:41 +0200 Subject: [PATCH] MAINT Parameters validation for datasets.make_friedman2 --- sklearn/datasets/_samples_generator.py | 7 +++++++ sklearn/tests/test_public_functions.py | 1 + 2 files changed, 8 insertions(+) diff --git a/sklearn/datasets/_samples_generator.py b/sklearn/datasets/_samples_generator.py index 2eba3f3e31046..bb17666a50191 100644 --- a/sklearn/datasets/_samples_generator.py +++ b/sklearn/datasets/_samples_generator.py @@ -1089,6 +1089,13 @@ def make_friedman1(n_samples=100, n_features=10, *, noise=0.0, random_state=None return X, y +@validate_params( + { + "n_samples": [Interval(Integral, 1, None, closed="left")], + "noise": [Interval(Real, 0, None, closed="left")], + "random_state": ["random_state"], + } +) def make_friedman2(n_samples=100, *, noise=0.0, random_state=None): """Generate the "Friedman #2" regression problem. diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py index 5770aca19e1cc..4bb6b418f0806 100644 --- a/sklearn/tests/test_public_functions.py +++ b/sklearn/tests/test_public_functions.py @@ -134,6 +134,7 @@ def _check_function_param_validation( "sklearn.datasets.make_circles", "sklearn.datasets.make_classification", "sklearn.datasets.make_friedman1", + "sklearn.datasets.make_friedman2", "sklearn.datasets.make_gaussian_quantiles", "sklearn.datasets.make_hastie_10_2", "sklearn.datasets.make_low_rank_matrix",