From 75af6c923f70082bd4535e54c09023bff94ebaca Mon Sep 17 00:00:00 2001 From: Guillaume Lemaitre Date: Sun, 8 Dec 2024 17:54:18 +0100 Subject: [PATCH] MAINT postpone erroring in 1.9 when dealing with integer in partial dependence --- sklearn/inspection/_partial_dependence.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sklearn/inspection/_partial_dependence.py b/sklearn/inspection/_partial_dependence.py index 7c777df364329..8b017e8aa70af 100644 --- a/sklearn/inspection/_partial_dependence.py +++ b/sklearn/inspection/_partial_dependence.py @@ -705,14 +705,14 @@ def partial_dependence( continue if _safe_indexing(X, feature_idx, axis=1).dtype.kind in "iu": - # TODO(1.8): raise a ValueError instead. + # TODO(1.9): raise a ValueError instead. warnings.warn( f"The column {feature!r} contains integer data. Partial " "dependence plots are not supported for integer data: this " "can lead to implicit rounding with NumPy arrays or even errors " "with newer pandas versions. Please convert numerical features" "to floating point dtypes ahead of time to avoid problems. " - "This will raise ValueError in scikit-learn 1.8.", + "This will raise ValueError in scikit-learn 1.9.", FutureWarning, ) # Do not warn again for other features to avoid spamming the caller.