From 5aaf29a69cb7f6c911abab6943315e5c8848f6cf Mon Sep 17 00:00:00 2001 From: Raghav RV Date: Mon, 14 Nov 2016 17:13:56 +0100 Subject: [PATCH 1/4] DOC Add whatnew for the 3 mod-sel bugfixes --- doc/whats_new.rst | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/doc/whats_new.rst b/doc/whats_new.rst index 6ef480f3baadd..62301a7ebac2d 100644 --- a/doc/whats_new.rst +++ b/doc/whats_new.rst @@ -104,6 +104,23 @@ Bug fixes the same result as the LassoLars implementation available in R (lars library). :issue:`7849` by `Jair Montoya Martinez`_ + - Fixed a bug where :func:`sklearn.model_selection.train_test_split` raised + an error when ``stratify`` is a list of string labels. :issue:`7593` by + `Raghav RV`_. + + - Fixed a bug where :class:`sklearn.model_selection.GridSearchCV` and + :class:`sklearn.model_selection.RandomizedSearchCV` were not pickleable + because of a pickling bug in ``np.ma.MaskedArray``. :issue:`7594` by + `Raghav RV`_. + + - All cross-validation utilities in :mod:`sklearn.model_selection` now + permit one time cross-validation splitters for the ``cv`` parameter. Also + non-deterministic cross-validation splitters (where multiple calls to + ``split`` produce dissimilar splits) can be used as ``cv`` parameter. + The :class:`sklearn.model_selection.GridSearchCV` will cross-validate each + parameter setting on the split produced by the first ``split`` call + to the cross-validation splitter. :issue:`7660` by `Raghav RV`_. + .. _changes_0_18_1: Version 0.18.1 From 61342d9542d3f2f785fc92fec0a5ab2805bd7b74 Mon Sep 17 00:00:00 2001 From: Raghav RV Date: Mon, 14 Nov 2016 17:30:45 +0100 Subject: [PATCH 2/4] Move to 0.18.1; Change name universally to Raghav RV --- doc/whats_new.rst | 55 +++++++++++++++++++++++------------------------ 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/doc/whats_new.rst b/doc/whats_new.rst index 62301a7ebac2d..bf95313f923b8 100644 --- a/doc/whats_new.rst +++ b/doc/whats_new.rst @@ -104,23 +104,6 @@ Bug fixes the same result as the LassoLars implementation available in R (lars library). :issue:`7849` by `Jair Montoya Martinez`_ - - Fixed a bug where :func:`sklearn.model_selection.train_test_split` raised - an error when ``stratify`` is a list of string labels. :issue:`7593` by - `Raghav RV`_. - - - Fixed a bug where :class:`sklearn.model_selection.GridSearchCV` and - :class:`sklearn.model_selection.RandomizedSearchCV` were not pickleable - because of a pickling bug in ``np.ma.MaskedArray``. :issue:`7594` by - `Raghav RV`_. - - - All cross-validation utilities in :mod:`sklearn.model_selection` now - permit one time cross-validation splitters for the ``cv`` parameter. Also - non-deterministic cross-validation splitters (where multiple calls to - ``split`` produce dissimilar splits) can be used as ``cv`` parameter. - The :class:`sklearn.model_selection.GridSearchCV` will cross-validate each - parameter setting on the split produced by the first ``split`` call - to the cross-validation splitter. :issue:`7660` by `Raghav RV`_. - .. _changes_0_18_1: Version 0.18.1 @@ -179,6 +162,22 @@ Bug fixes has less number of classes than the total data. :issue:`7799` by `Srivatsan Ramesh`_ + - Fixed a bug where :func:`sklearn.model_selection.train_test_split` raised + an error when ``stratify`` is a list of string labels. :issue:`7593` by + `Raghav RV`_. + + - Fixed a bug where :class:`sklearn.model_selection.GridSearchCV` and + :class:`sklearn.model_selection.RandomizedSearchCV` were not pickleable + because of a pickling bug in ``np.ma.MaskedArray``. :issue:`7594` by + `Raghav RV`_. + + - All cross-validation utilities in :mod:`sklearn.model_selection` now + permit one time cross-validation splitters for the ``cv`` parameter. Also + non-deterministic cross-validation splitters (where multiple calls to + ``split`` produce dissimilar splits) can be used as ``cv`` parameter. + The :class:`sklearn.model_selection.GridSearchCV` will cross-validate each + parameter setting on the split produced by the first ``split`` call + to the cross-validation splitter. :issue:`7660` by `Raghav RV`_. API changes summary ------------------- @@ -374,7 +373,7 @@ Model selection and evaluation - The cross-validation iterators are replaced by cross-validation splitters available from :mod:`sklearn.model_selection`, allowing for nested cross-validation. See :ref:`model_selection_changes` for more information. - :issue:`4294` by `Raghav R V`_. + :issue:`4294` by `Raghav RV`_. Enhancements ............ @@ -491,7 +490,7 @@ Model evaluation and meta-estimators - The new ``cv_results_`` attribute of :class:`model_selection.GridSearchCV` (and :class:`model_selection.RandomizedSearchCV`) can be easily imported into pandas as a ``DataFrame``. Ref :ref:`model_selection_changes` for - more information. :issue:`6697` by `Raghav R V`_. + more information. :issue:`6697` by `Raghav RV`_. - Generalization of :func:`model_selection.cross_val_predict`. One can pass method names such as `predict_proba` to be used in the cross @@ -501,7 +500,7 @@ Model evaluation and meta-estimators - The training scores and time taken for training followed by scoring for each search candidate are now available at the ``cv_results_`` dict. See :ref:`model_selection_changes` for more information. - :issue:`7325` by :user:`Eugene Chen ` and `Raghav R V`_. + :issue:`7325` by :user:`Eugene Chen ` and `Raghav RV`_. Metrics @@ -516,7 +515,7 @@ Metrics :issue:`7419` by :user:`Gregory Stupp ` and `Joel Nothman`_. - Add ``sample_weight`` parameter to :func:`metrics.matthews_corrcoef`. - By :user:`Jatin Shah ` and `Raghav R V`_. + By :user:`Jatin Shah ` and `Raghav RV`_. - Speed up :func:`metrics.silhouette_score` by using vectorized operations. By `Manoj Kumar`_. @@ -747,13 +746,13 @@ Model evaluation and meta-estimators :mod:`sklearn.learning_curve` have been deprecated and the classes and functions have been reorganized into the :mod:`sklearn.model_selection` module. Ref :ref:`model_selection_changes` for more information. - :issue:`4294` by `Raghav R V`_. + :issue:`4294` by `Raghav RV`_. - The ``grid_scores_`` attribute of :class:`model_selection.GridSearchCV` and :class:`model_selection.RandomizedSearchCV` is deprecated in favor of the attribute ``cv_results_``. Ref :ref:`model_selection_changes` for more information. - :issue:`6697` by `Raghav R V`_. + :issue:`6697` by `Raghav RV`_. - The parameters ``n_iter`` or ``n_folds`` in old CV splitters are replaced by the new parameter ``n_splits`` since it can provide a consistent @@ -774,7 +773,7 @@ Model evaluation and meta-estimators :class:`model_selection.LeavePGroupsOut` is renamed to ``groups``. Additionally in :class:`model_selection.LeavePGroupsOut`, the parameter ``n_labels`` is renamed to ``n_groups``. - :issue:`6660` by `Raghav R V`_. + :issue:`6660` by `Raghav RV`_. Code Contributors ----------------- @@ -1331,7 +1330,7 @@ Mathieu Blondel, Matt Krump, Matti Lyra, Maxim Kolganov, mbillinger, mhg, Michael Heilman, Michael Patterson, Miroslav Batchkarov, Nelle Varoquaux, Nicolas, Nikolay Mayorov, Olivier Grisel, Omer Katz, Óscar Nájera, Pauli Virtanen, Peter Fischer, Peter Prettenhofer, Phil Roth, pianomania, Preston -Parry, Raghav R V, Rob Zinkov, Robert Layton, Rohan Ramanath, Saket Choudhary, +Parry, Raghav RV, Rob Zinkov, Robert Layton, Rohan Ramanath, Saket Choudhary, Sam Zhang, santi, saurabh.bansod, scls19fr, Sebastian Raschka, Sebastian Saeger, Shivan Sornarajah, SimonPL, sinhrks, Skipper Seabold, Sonny Hu, sseg, Stephen Hoover, Steven De Gryze, Steven Seguin, Theodore Vasiloudis, Thomas @@ -1559,7 +1558,7 @@ Enhancements in their constructor. By `Manoj Kumar`_. - Added decision function for :class:`multiclass.OneVsOneClassifier` - By `Raghav R V`_ and :user:`Kyle Beauchamp `. + By `Raghav RV`_ and :user:`Kyle Beauchamp `. - :func:`neighbors.kneighbors_graph` and :func:`radius_neighbors_graph` support non-Euclidean metrics. By `Manoj Kumar`_ @@ -1806,7 +1805,7 @@ API changes summary - From now onwards, all estimators will uniformly raise ``NotFittedError`` (:class:`utils.validation.NotFittedError`), when any of the ``predict`` - like methods are called before the model is fit. By `Raghav R V`_. + like methods are called before the model is fit. By `Raghav RV`_. - Input data validation was refactored for more consistent input validation. The ``check_arrays`` function was replaced by ``check_array`` @@ -4768,7 +4767,7 @@ David Huard, Dave Morrill, Ed Schofield, Travis Oliphant, Pearu Peterson. .. _Noel Dawe: https://github.com/ndawe -.. _Raghav R V: https://github.com/raghavrv +.. _Raghav RV: https://github.com/raghavrv .. _Tom Dupre la Tour: https://github.com/TomDLT From 99082d9d88056f1de315fbb85b63fce8f545da08 Mon Sep 17 00:00:00 2001 From: Raghav RV Date: Mon, 14 Nov 2016 17:33:24 +0100 Subject: [PATCH 3/4] Raghav R V --> Raghav RV --- .mailmap | 2 +- doc/about.rst | 4 ++-- sklearn/model_selection/_split.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.mailmap b/.mailmap index e26953687323f..4a05a7e5864e4 100644 --- a/.mailmap +++ b/.mailmap @@ -93,7 +93,7 @@ Olivier Grisel Olivier Hervieu Paul Butler Peter Prettenhofer -Raghav R V +Raghav RV Robert Layton Roman Sinayev Roman Sinayev diff --git a/doc/about.rst b/doc/about.rst index 92b1a201ef6a2..f277f075b85bd 100644 --- a/doc/about.rst +++ b/doc/about.rst @@ -96,7 +96,7 @@ Environment also funds several students to work on the project part-time. :target: http://cds.nyu.edu/mooresloan/ `Télécom Paristech `_ funds Manoj Kumar (2014), -Tom Dupré la Tour (2015), Raghav R V (2015-2016) and Thierry Guillemot (2016) to +Tom Dupré la Tour (2015), Raghav RV (2015-2016) and Thierry Guillemot (2016) to work on scikit-learn. .. image:: themes/scikit-learn/static/img/telecom.png @@ -114,7 +114,7 @@ program. - 2012 - `Vlad Niculae`_, Immanuel Bayer. - 2013 - Kemal Eren, Nicolas Trésegnie - 2014 - Hamzeh Alsalhi, Issam Laradji, Maheshakya Wijewardena, Manoj Kumar. -- 2015 - `Raghav R V `_, Wei Xue +- 2015 - `Raghav RV `_, Wei Xue - 2016 - `Nelson Liu `_, `YenChen Lin `_ It also provided funding for sprints and events around scikit-learn. If diff --git a/sklearn/model_selection/_split.py b/sklearn/model_selection/_split.py index 7d26a0d5b0a5c..8ec8bdf2a5166 100644 --- a/sklearn/model_selection/_split.py +++ b/sklearn/model_selection/_split.py @@ -6,7 +6,7 @@ # Author: Alexandre Gramfort , # Gael Varoquaux , # Olivier Grisel -# Raghav R V +# Raghav RV # License: BSD 3 clause From 4e3bcdbdb1fb542d6eee1aff02937a7dad774f57 Mon Sep 17 00:00:00 2001 From: Raghav RV Date: Mon, 14 Nov 2016 17:36:32 +0100 Subject: [PATCH 4/4] Edit mailmap to include my other email --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 4a05a7e5864e4..22ef4b78b9bf7 100644 --- a/.mailmap +++ b/.mailmap @@ -94,6 +94,7 @@ Olivier Hervieu Paul Butler Peter Prettenhofer Raghav RV +Raghav RV Robert Layton Roman Sinayev Roman Sinayev