Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CircleCI fails when merged into main #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TimotheeMathieu opened this issue Feb 24, 2023 · 2 comments · Fixed by #163
Closed

CircleCI fails when merged into main #162

TimotheeMathieu opened this issue Feb 24, 2023 · 2 comments · Fixed by #163
Assignees
@rth

Comments

@TimotheeMathieu
Copy link
Contributor

TimotheeMathieu commented Feb 24, 2023 •
edited
Loading

The check for circleci fails when merging a PR but it is green when running inside the PR.
I updated circle ci to last syntax (#160 ) but this does not solve the problem. From what I see (https://discuss.circleci.com/t/git-github-com-permission-denied-publickey-on-repo-that-previously-worked/37763/4) it should be a circleci problem and some key has to be regenerated.
@TimotheeMathieu
Copy link
Contributor Author

TimotheeMathieu commented Feb 25, 2023 •
edited
Loading

Another possibility is to just use github action which is easier to maintain, it seems kind of overkill to use circleci just for black and flake8.

@rth
Copy link
Contributor

rth commented Feb 26, 2023 •
edited
Loading

+1 to switch away from CircleCI for this use case. The easiest would be to enable pre-commit.ci which runs the checks in the already existing .pre-commit-config.yml. If interested let me know and I should be able to enable it.

@TimotheeMathieu TimotheeMathieu linked a pull request Feb 26, 2023 that will close this issue
[MAINT] Remove circleci #163
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rth rth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MAINT] Remove circleci TimotheeMathieu/scikit-learn-extra
2 participants
@rth @TimotheeMathieu