-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Comparing changes
Open a pull request
base repository: openai/openai-agents-python
base: main
head repository: scotthamilton77/openai-agents-python
compare: main
- 10 commits
- 12 files changed
- 2 contributors
Commits on May 25, 2025
-
Added ability for agents to carry their own TTS settings and have the…
… pipeline activate it prior to streaming results.
Configuration menu - View commit details
-
Copy full SHA for 04df256 - Browse repository at this point
Copy the full SHA 04df256View commit details -
docs: add voice agent configuration guide with usage examples and imp…
…lementation details
Configuration menu - View commit details
-
Copy full SHA for bda9cb3 - Browse repository at this point
Copy the full SHA bda9cb3View commit details
Commits on May 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 3d72426 - Browse repository at this point
Copy the full SHA 3d72426View commit details -
Configuration menu - View commit details
-
Copy full SHA for 168464f - Browse repository at this point
Copy the full SHA 168464fView commit details -
Test: Update and extend tests for voice configuration handling. (#1)
This commit updates the test suite to ensure comprehensive coverage for the recent changes to how voice configurations (TTS model, settings) are managed and resolved within the voice agent system. Key changes: - **`tests/voice/test_pipeline.py`**: - Added tests for `VoicePipeline.get_effective_voice_configuration` to verify correct prioritization of workflow-provided vs. pipeline-default configurations. - Updated existing pipeline run tests (`run_single_turn`, `run_multi_turn`) to ensure they correctly use `VoiceConfiguration` provided by the workflow. This involved enhancing `FakeTTS` and `FakeWorkflow`. - Added new tests for pipeline-workflow interaction scenarios, covering cases where model name and settings are mixed and matched between workflow and pipeline configurations. A `MockModelProvider` was introduced for better control over TTS model resolution in tests. - **`tests/voice/test_workflow.py`**: - Added tests for `VoiceWorkflowBase.get_voice_configuration` to ensure it correctly fetches configurations from its `current_agent`. - For `SingleAgentVoiceWorkflow`: - Tested retrieval of `VoiceConfiguration` from its agent. - Tested that `current_agent` is correctly updated after a simulated handoff. - Verified that `on_run` and `on_agent_change` callbacks are invoked as expected. Mocked `RunResultStreaming` for handoff simulation. - **`tests/voice/test_voiceagent.py` (New file)**: - Created to test components from `src/agents/voice/voiceagent.py`. - Added tests for `VoiceAgentMixin` to ensure proper storage and retrieval of `VoiceConfiguration`. - Added tests for `with_voice_configuration` and `with_voice_config` helper functions, verifying they correctly create new agent instances with the specified voice configurations and preserve original agent details. - **`tests/voice/test_model.py` (New file)**: - Created to test components from `src/agents/voice/model.py`. - Added tests for `VoiceConfiguration.get_effective_model()`, covering scenarios for model resolution (name vs. instance) and caching behavior. - **`tests/voice/fake_models.py`**: - Enhanced `FakeTTS` to store `last_run_settings` and accept a `name` for easier instance identification in tests. The existing tests in `tests/voice/test_openai_tts.py`, `tests/voice/test_input.py`, and `tests/voice/test_openai_stt.py` were reviewed and found not to require changes for this specific set of refactorings. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d5bebd5 - Browse repository at this point
Copy the full SHA d5bebd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 610150f - Browse repository at this point
Copy the full SHA 610150fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f0f6cc - Browse repository at this point
Copy the full SHA 2f0f6ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d877af - Browse repository at this point
Copy the full SHA 8d877afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d282f9 - Browse repository at this point
Copy the full SHA 5d282f9View commit details -
test: add comprehensive test suite for VoiceAgent configuration and i…
…nheritance behavior
Configuration menu - View commit details
-
Copy full SHA for 0e6e9bd - Browse repository at this point
Copy the full SHA 0e6e9bdView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main