Thanks to visit codestin.com
Credit goes to github.com

Skip to content

oauth_timestamp missing or invalid (suggestion for improvement with code) #1067

@fabst2w

Description

@fabst2w

According to https://oauth.net/core/1.0a/#nonce

[...] the timestamp is expressed in the number of seconds since January 1, 1970 00:00:00 GMT [...]

The current implementation of com.github.scribejava.core.services.TimestampServiceImpl.Timer.getMilis() returns System.currentTimeMillis();.
I think that this fulfills the specification only when the application runs in GMT time zone.

My application is running in Germany. And for a requests to a server my application got the answer "oauth_timestamp missing or invalid".
In the API docs there is a hint that "[...] requests where the timestamp differs more than 10 minutes from the current UTC time will fail."

Changing the implementation of com.github.scribejava.core.services.TimestampServiceImpl.Timer.getMilis() to return Instant.now().getEpochSecond()*1000L; works fine.
So I think that this should be the general implementation to have an oauth_timestamp independently from the system's time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions