Do not pass empty object list to linker (HaxeFoundation#1184)

tobil4sk · web-flow · commit 3acb85519e18 · 2025-04-06T08:30:15.000+02:00
This situation may arise in some situations with the compile cache
enabled. Some linkers (such as libtool on mac) throw an error if an
object list is empty, so it is not safe to pass it in.
diff --git a/tools/hxcpp/Linker.hx b/tools/hxcpp/Linker.hx
@@ -251,7 +251,8 @@ class Linker
          }
 
          // Place list of obj files in a file called "all_objs"
-         if (mFromFile!="")
+         // In some situations with the compile cache, we might have an empty list
+         if (mFromFile!="" && objs.length!=0)
          {
             PathManager.mkdir(tmpDir);
             var fname = tmpDir + "/all_objs";

Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,8 @@ class Linker`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`// Place list of obj files in a file called "all_objs"`
`254`		`- if (mFromFile!="")`
	`254`	`+ // In some situations with the compile cache, we might have an empty list`
	`255`	`+ if (mFromFile!="" && objs.length!=0)`
`255`	`256`	`{`
`256`	`257`	`PathManager.mkdir(tmpDir);`
`257`	`258`	`var fname = tmpDir + "/all_objs";`