fix(plugin-typescript): fix issues in no-misused-new rule

armano2 · JamesHenry · commit 56bb30840f92 · 2019-01-18T07:42:16.000-05:00
diff --git a/packages/eslint-plugin-typescript/lib/rules/adjacent-overload-signatures.js b/packages/eslint-plugin-typescript/lib/rules/adjacent-overload-signatures.js
@@ -49,8 +49,7 @@ module.exports = {
         }
         case 'TSDeclareFunction':
         case 'FunctionDeclaration':
-        case 'TSNamespaceFunctionDeclaration':
-        case 'TSEmptyBodyFunctionDeclaration': {
+        case 'TSNamespaceFunctionDeclaration': {
           return member.id && member.id.name;
         }
         case 'TSMethodSignature': {
diff --git a/packages/eslint-plugin-typescript/lib/rules/no-misused-new.js b/packages/eslint-plugin-typescript/lib/rules/no-misused-new.js
@@ -66,7 +66,7 @@ module.exports = {
 
     return {
       'TSInterfaceBody > TSConstructSignatureDeclaration'(node) {
-        if (isMatchingParentType(node.parent.parent, node.typeAnnotation)) {
+        if (isMatchingParentType(node.parent.parent, node.returnType)) {
           // constructor
           context.report({
             node,
@@ -84,7 +84,7 @@ module.exports = {
         if (
           node.value &&
           (node.value.type === 'TSEmptyBodyFunctionExpression' ||
-            node.value.type === 'TSEmptyBodyFunctionDeclaration')
+            (node.value.type === 'TSDeclareFunction' && !node.value.body))
         ) {
           if (isMatchingParentType(node.parent.parent, node.value.returnType)) {
             context.report({

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,7 @@ module.exports = {`
`49`	`49`	`}`
`50`	`50`	`case 'TSDeclareFunction':`
`51`	`51`	`case 'FunctionDeclaration':`
`52`		`- case 'TSNamespaceFunctionDeclaration':`
`53`		`- case 'TSEmptyBodyFunctionDeclaration': {`
	`52`	`+ case 'TSNamespaceFunctionDeclaration': {`
`54`	`53`	`return member.id && member.id.name;`
`55`	`54`	`}`
`56`	`55`	`case 'TSMethodSignature': {`