Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix: oracle initialize script index_name is duplicate #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 2 commits into from
Jan 3, 2023
Merged

bugfix: oracle initialize script index_name is duplicate #5224

funky-eyes merged 2 commits into from
Jan 3, 2023

Conversation

@PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Jan 3, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复：oracle.sql脚本执行错误，索引名重复

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023 •
edited
Loading

Codecov Report

Merging #5224 (fa764eb) into develop (e423b38) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5224      +/-   ##
=============================================
- Coverage      48.48%   48.45%   -0.04%     
+ Complexity      4139     4135       -4     
=============================================
  Files            743      743              
  Lines          26518    26518              
  Branches        3294     3294              
=============================================
- Hits           12858    12848      -10     
- Misses         12261    12271      +10     
  Partials        1399     1399
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.09%) ⬇️
...erver/storage/file/session/FileSessionManager.java 47.77% <0.00%> (-0.64%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️

@funky-eyes funky-eyes changed the title script/server/db/oracle.sql index_name is duplicate bugfix: oracle initialize script index_name is duplicate Jan 3, 2023
funky-eyes
funky-eyes approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jsbxyyx PTAL

jsbxyyx
jsbxyyx approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx
Copy link
Member

jsbxyyx commented Jan 3, 2023

develop.md补充下作者和pr信息

l81893521
l81893521 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. first-time contributor first-time contributor module/script script module labels Jan 3, 2023
@funky-eyes funky-eyes merged commit 886f439 into apache:develop Jan 3, 2023
slievrly
slievrly reviewed Jan 7, 2023
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @PeppaO thanks for your contributions.

@wangliang181230 wangliang181230 added this to the 1.7.0 milestone Feb 7, 2023
@PeppaO PeppaO deleted the fix_PeppaO branch December 14, 2023 05:30
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@PeppaO
bugfix: oracle initialize script index_name is duplicate (apache#5224)
92db548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slievrly slievrly slievrly left review comments

@l81893521 l81893521 l81893521 approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

@jsbxyyx jsbxyyx jsbxyyx approved these changes

Assignees

No one assigned

Labels

first-time contributor first-time contributor module/script script module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

8 participants

@PeppaO @CLAassistant @codecov-commenter @jsbxyyx @l81893521 @slievrly @funky-eyes @wangliang181230