Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix: After 1.6.0, auto-increment of pgsql/oracle pk columns are no longer supported #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 7 commits into from
Feb 3, 2023
Merged

bugfix: After 1.6.0, auto-increment of pgsql/oracle pk columns are no longer supported #5294

funky-eyes merged 7 commits into from
Feb 3, 2023

Conversation

@isharpever
Copy link
Contributor

@isharpever isharpever commented Feb 3, 2023 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#5287 #5288 合并到2.x

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.0.0 milestone Feb 3, 2023
@funky-eyes funky-eyes added module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug. labels Feb 3, 2023
funky-eyes
funky-eyes approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

isharpever added a commit to isharpever/seata that referenced this pull request Feb 3, 2023
@isharpever
register the PR change apache#5294
58b3c9b
@isharpever isharpever force-pushed the fix_1.6.1_pk_auto_increment branch from 58b3c9b to 70a0f54 Compare February 3, 2023 04:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #5294 (58b3c9b) into 2.x (fb0bc76) will increase coverage by 0.02%.
The diff coverage is 94.73%.

❗ Current head 58b3c9b differs from pull request most recent head 70a0f54. Consider uploading reports for the commit 70a0f54 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5294      +/-   ##
============================================
+ Coverage     48.46%   48.49%   +0.02%     
- Complexity     4170     4188      +18     
============================================
  Files           764      764              
  Lines         26844    26880      +36     
  Branches       3345     3357      +12     
============================================
+ Hits          13010    13035      +25     
- Misses        12447    12457      +10     
- Partials       1387     1388       +1
Impacted Files Coverage Δ
...m/datasource/exec/oracle/OracleInsertExecutor.java 83.78% <94.73%> (+10.09%) ⬆️
...urce/exec/postgresql/PostgresqlInsertExecutor.java 67.92% <94.73%> (+16.49%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...o/seata/server/session/AbstractSessionManager.java 62.31% <0.00%> (-2.90%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 47.59% <0.00%> (-2.41%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 59.80% <0.00%> (-0.65%) ⬇️
...erver/storage/file/session/FileSessionManager.java 49.04% <0.00%> (-0.64%) ⬇️
...o/seata/rm/datasource/exec/BaseInsertExecutor.java 62.38% <0.00%> (+0.45%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

@funky-eyes funky-eyes merged commit 0112719 into apache:2.x Feb 3, 2023
@funky-eyes funky-eyes mentioned this pull request May 29, 2023
Closed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@isharpever
bugfix: After 1.6.0, auto-increment of pgsql/oracle pk columns are no…
d21b23a 
… longer supported (apache#5294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@isharpever @codecov-commenter @funky-eyes