bugfix: don't remove GlobalSession when retry rollback or retry commit timeout #5299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Correct the comment on MySQLUndoUpdateExecutor#UPDATE_SQL_TEMPLATE (apache#5297) 2. Do not remove GlobalSession when retry rollback or retry commit timeout (apache#5293)
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5299 +/- ##
=============================================
- Coverage 48.83% 48.80% -0.04%
+ Complexity 4182 4178 -4
=============================================
Files 743 743
Lines 26626 26622 -4
Branches 3333 3333
=============================================
- Hits 13002 12992 -10
- Misses 12219 12225 +6
Partials 1405 1405
|
slievrly
reviewed
Feb 6, 2023
Member
slievrly
left a comment
There was a problem hiding this comment.
add change in develop.md not inn 1.6.1.md
|
|
||
| /** | ||
| * UPDATE a SET x = ?, y = ?, z = ? WHERE pk1 in (?) pk2 in (?) | ||
| * UPDATE a SET x = ?, y = ?, z = ? WHERE pk1 =? and pk2 =? |
Member
There was a problem hiding this comment.
This will be fix in the next pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5297
fixes #5295