Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix: fix console jwt log error #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slievrly merged 4 commits into from
Feb 20, 2023
Merged

bugfix: fix console jwt log error #5347

slievrly merged 4 commits into from
Feb 20, 2023

Conversation

@jumtp
Copy link
Contributor

@jumtp jumtp commented Feb 16, 2023 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fix: #5324

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added first-time contributor first-time contributor module/server server module module/console type: bug Category issues or prs related to bug. labels Feb 16, 2023
@jumtp
Copy link
Contributor Author

jumtp commented Feb 16, 2023

完蛋，我加到主分支里面了。需要重新提交吗？

funky-eyes
funky-eyes reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So changed why there is no 401 problem? 401 reason is because the access path is restricted, console-fe/public/ itself is allowed to visit, modify the url reason is because we previously wrote the address is not right to lead to access 404 jump to error and then be intercepted to lead to 401 of this process?
这么改动了为什么就不存在401问题了呢？401的原因是因为访问路径被限制，console-fe/public/本身就是允许访问的，修改url的原因是因为我们之前写的地址不对导致访问404跳转error再被拦截导致401的这个过程吗

@funky-eyes
Copy link
Contributor

funky-eyes commented Feb 16, 2023

完蛋，我加到主分支里面了。需要重新提交吗？

bugfix的pr是develop和2.x分支都要提交的

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023 •
edited
Loading

Codecov Report

Merging #5347 (bef6f48) into 2.x (a20ad42) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head bef6f48 differs from pull request most recent head 8aadd00. Consider uploading reports for the commit 8aadd00 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5347      +/-   ##
============================================
- Coverage     48.86%   48.85%   -0.01%     
- Complexity     4312     4315       +3     
============================================
  Files           771      771              
  Lines         27290    27290              
  Branches       3396     3396              
============================================
- Hits          13334    13333       -1     
- Misses        12554    12556       +2     
+ Partials       1402     1401       -1
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 70.30% <0.00%> (-0.76%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 45.22% <0.00%> (+0.41%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 76.60% <0.00%> (+0.51%) ⬆️
...ver/storage/redis/session/RedisSessionManager.java 65.71% <0.00%> (+2.85%) ⬆️

@jumtp
Copy link
Contributor Author

jumtp commented Feb 16, 2023

So changed why there is no 401 problem? 401 reason is because the access path is restricted, console-fe/public/ itself is allowed to visit, modify the url reason is because we previously wrote the address is not right to lead to access 404 jump to error and then be intercepted to lead to 401 of this process? 这么改动了为什么就不存在401问题了呢？401的原因是因为访问路径被限制，console-fe/public/本身就是允许访问的，修改url的原因是因为我们之前写的地址不对导致访问404跳转error再被拦截导致401的这个过程吗

After the seata-console project is packaged, the console-fe/public/ folder does not exist. You can unzip the jar and find that bootstrap.css, console1412.css and other files exist under the css folder

seata-console项目打包后.并不存在console-fe/public/文件夹.你可以解压jar发现.bootstrap.css,console1412.css等文件都存在css文件夹下面

seata-jwt-error1

After you decompress, you can directly modify the static/index file, modify the paths of the .bootstrap.css and console1412.css files to achieve the effect of importing successfully
当你解压过后,可以直接修改 static/index 文件，把.bootstrap.css,console1412.css文件的路径修改一下也可以达到引入成功的效果

seata-jwt-error2

@jumtp
Copy link
Contributor Author

jumtp commented Feb 16, 2023

完蛋，我加到主分支里面了。需要重新提交吗？

bugfix的pr是develop和2.x分支都要提交的

那我现在以同样的方式提交吗，还是说需要我rebase一下

@slievrly
Copy link
Member

slievrly commented Feb 17, 2023

完蛋，我加到主分支里面了。需要重新提交吗？

bugfix的pr是develop和2.x分支都要提交的

那我现在以同样的方式提交吗，还是说需要我rebase一下

just add change log on：
https://github.com/seata/seata/blob/2.x/changes/en-us/2.0.0.md
https://github.com/seata/seata/blob/2.x/changes/zh-cn/2.0.0.md

liuqiufeng
liuqiufeng reviewed Feb 18, 2023
View reviewed changes
console/src/main/resources/static/index.html Outdated
@@ -24,8 +24,8 @@
<title>Seata</title>

<link rel="shortcut icon" href="console-fe/public/img/seata_logo_small.jpeg" type="image/x-icon">
Copy link
Contributor

@liuqiufeng liuqiufeng Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortcut icon也一起改下吧

Copy link
Contributor Author

@jumtp jumtp Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortcut icon也一起改下吧

大意了，已添加~

liuqiufeng
liuqiufeng approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@liuqiufeng liuqiufeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jumtp jumtp requested a review from liuqiufeng February 19, 2023 01:52
slievrly
slievrly approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

slievrly commented Feb 20, 2023

I have reproduced the issue.
image

@slievrly slievrly changed the title bugfix: fix jwt log error bugfix: fix console jwt log error Feb 20, 2023
@slievrly
Copy link
Member

slievrly commented Feb 20, 2023

@jumtp thanks for your contribution.

@slievrly slievrly merged commit 83bfaf3 into apache:2.x Feb 20, 2023
@slievrly slievrly added this to the 2.0.0 milestone Feb 21, 2023
@funky-eyes funky-eyes mentioned this pull request Mar 30, 2023
Closed
@slievrly slievrly mentioned this pull request Jul 1, 2023
Merged
1 task
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@jumtp
bugfix: fix console jwt log error (apache#5347)
d2d53b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes left review comments

@slievrly slievrly slievrly approved these changes

@liuqiufeng liuqiufeng liuqiufeng approved these changes

Assignees

No one assigned

Labels

first-time contributor first-time contributor module/console module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

jwt log error

5 participants

@jumtp @funky-eyes @codecov-commenter @slievrly @liuqiufeng