bugfix: fix when TC returns RollbackFailed FailureHandler not executed #5362
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5362 +/- ##
============================================
+ Coverage 48.53% 48.55% +0.01%
+ Complexity 4301 4300 -1
============================================
Files 775 771 -4
Lines 27372 27358 -14
Branches 3408 3410 +2
============================================
- Hits 13285 13283 -2
+ Misses 12684 12671 -13
- Partials 1403 1404 +1
|
| code = TransactionalExecutor.Code.TimeoutRollback; | ||
| break; | ||
| case Rollbacked: | ||
| default: |
There was a problem hiding this comment.
我觉得只有Rollbacked是RollbackDone吧？如果真的到default了是不是该抛个其他异常了？
There was a problem hiding this comment.
Consider the compatibility of high and low versions (client is a low version, server is a high version and the new state), do not throw exceptions.You can just print a log.
| case RollbackRetrying: | ||
| code = TransactionalExecutor.Code.RollbackRetrying; | ||
| break; | ||
| case TimeoutRollbacking: |
There was a problem hiding this comment.
The next pr will removes the TimeRollback state of the client
Ⅰ. Describe what this PR did
fixes :#5231
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews