Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@slievrly
Copy link
Member

@slievrly slievrly commented Feb 21, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix transaction timeout on client side not execute hook and failureHandler

Ⅱ. Does this pull request fix one issue?

fix #5374

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #5373 (6f1103d) into 2.x (d1c4b78) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #5373   +/-   ##
=========================================
  Coverage     48.56%   48.57%           
+ Complexity     4313     4312    -1     
=========================================
  Files           775      775           
  Lines         27390    27391    +1     
  Branches       3406     3406           
=========================================
+ Hits          13303    13305    +2     
+ Misses        12686    12684    -2     
- Partials       1401     1402    +1     
Impacted Files Coverage Δ
...in/java/io/seata/tm/api/TransactionalTemplate.java 58.44% <0.00%> (-0.39%) ⬇️
...ver/storage/redis/lock/RedisDistributedLocker.java 59.09% <0.00%> (-13.64%) ⬇️
...erver/storage/file/session/FileSessionManager.java 61.14% <0.00%> (-0.64%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 45.86% <0.00%> (+0.41%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 77.37% <0.00%> (+0.77%) ⬆️
...in/java/io/seata/server/session/SessionHelper.java 65.45% <0.00%> (+1.81%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 5aa6c29 into apache:2.x Feb 28, 2023
@wangliang181230 wangliang181230 added this to the 2.0.0 milestone Apr 3, 2023
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when client transaction timeout before commit , not execute hook and failureHandler

4 participants