Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Mar 16, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3388 #2791

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes
Copy link
Contributor

image

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.7.0 milestone Mar 16, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: XA XA transaction mode module/rm-datasource rm-datasource module labels Mar 16, 2023
@funky-eyes
Copy link
Contributor

@funky-eyes
Copy link
Contributor

/home/runner/work/seata/seata/rm-datasource/src/main/java/io/seata/rm/datasource/util/SeataXAResource.java:2: Line does not match expected header line of '[*\s]Copyright 1999-2019 Seata.io Group.'. [RegexpHeader]

@funky-eyes funky-eyes changed the title fix oracle xa mode cannnot be used By same database bugfix: oracle xa mode cannnot be used By same database Mar 16, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit cdbc4c0 into apache:develop Mar 17, 2023
l81893521 pushed a commit to l81893521/seata that referenced this pull request Mar 28, 2023
@PeppaO PeppaO deleted the fix_oracle branch December 14, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode: XA XA transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants