bugfix: fix using @GlobalTransactional in provider ShouldNeverHappenException thrown #5462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Mar 22, 2023
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
这个pr作为临时解决方案是可以的,在处于参与者时,直接将originalException抛出去即可,但是更深层次去看,参与者是否有必要在transactionalTemplate里包装异常为ExecutionException? 如果业务一样自己用我们的模板方法去使用,最终抛出的是ExecutionException,而不是业务异常,是否应该在transactionalTemplate中处理?绕过外层GlobalTransactionalInterceptorHandler中的catch
funky-eyes
reviewed
Mar 22, 2023
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
这个pr作为临时解决方案是可以的,在处于参与者时,直接将originalException抛出去即可,但是更深层次去看,参与者是否有必要在transactionalTemplate里包装异常为ExecutionException? 如果业务一样自己用我们的模板方法去使用,最终抛出的是ExecutionException,而不是业务异常,是否应该在transactionalTemplate中处理?绕过外层GlobalTransactionalInterceptorHandler中的catch
Member
|
@pengten Pls add change in the following files: |
…everHappenException will be thrown
…everHappenException will be thrown
|
|
…everHappenException will be thrown
…erHappenException will be thrown
…erHappenException will be thrown
liuqiufeng
pushed a commit
to liuqiufeng/seata
that referenced
this pull request
Apr 20, 2023
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…everHappenException will be thrown
Ⅰ. Describe what this PR did
fix #5460
#5459
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews