feature:docker image supports JVM parameter injection #5529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix_#5521 # Conflicts: # distribution/bin/seata-server.sh
slievrly
reviewed
May 11, 2023
| before_script: | ||
| - if [ "$TRAVIS_JDK_VERSION" == "openjdk8" ]; then | ||
| export IMAGE_NAME="openjdk:8u212-jre-alpine"; | ||
| export IMAGE_NAME="openjdk:8-jre-slim"; |
Member
There was a problem hiding this comment.
This file is currently deprecated.
Note that our base image uses openjdk:8u342
Member
Author
There was a problem hiding this comment.
ok.i will check it out.
slievrly
approved these changes
Jun 12, 2023
Member
slievrly
left a comment
There was a problem hiding this comment.
After the merger will be validity test workflow.
Pil0tXia
added a commit
to Pil0tXia/seata
that referenced
this pull request
Jun 14, 2023
my change 2 optimize: optimize channel availability thread log output (apache#5563) feature:docker image supports JVM parameter injection (apache#5529) test: add unit test for transaction messages (apache#5637) feature: support trace the transaction link according to the XID (apache#5600) test: add unit test case for ExporterType/RegistryType (apache#5622)
Pil0tXia
pushed a commit
to Pil0tXia/seata
that referenced
this pull request
Jun 14, 2023
my change 2 optimize: optimize channel availability thread log output (apache#5563) feature:docker image supports JVM parameter injection (apache#5529) test: add unit test for transaction messages (apache#5637) feature: support trace the transaction link according to the XID (apache#5600) test: add unit test case for ExporterType/RegistryType (apache#5622) optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623) optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623) optimize: support case-sensitive attributes for table and column metadata (apache#5553)
Pil0tXia
pushed a commit
to Pil0tXia/seata
that referenced
this pull request
Jun 14, 2023
my change 2 optimize: optimize channel availability thread log output (apache#5563) feature:docker image supports JVM parameter injection (apache#5529) test: add unit test for transaction messages (apache#5637) feature: support trace the transaction link according to the XID (apache#5600) test: add unit test case for ExporterType/RegistryType (apache#5622) optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623) optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623) optimize: support case-sensitive attributes for table and column metadata (apache#5553) (+14 squashed commit) Squashed commit: [c97f409] mychange 1 my change 2 optimize: optimize channel availability thread log output (apache#5563) feature:docker image supports JVM parameter injection (apache#5529) test: add unit test for transaction messages (apache#5637) feature: support trace the transaction link according to the XID (apache#5600) test: add unit test case for ExporterType/RegistryType (apache#5622) [8f9bba2] bugfix: fix the `asyncCommit` and `queueToRetryCommit` always failed in db mode (apache#5604) [b2d4584] bugfix: fix log in participant transaction role (apache#5594) [d0d012c] feature: support sqlserver in AT mode (apache#3887) [54bd3ca] feature：support MS SqlServer on the server side of AT mode (apache#4033) [d1e6e6b] bugfix: grpc interceptor xid unbinding problem (apache#5577) [0b49e06] optimize: The common fence clean task is only initiated when useTCCFence is set to true (apache#5576) [7e40e05] bugfix: fix mariadb rollback failed (apache#5558) [ee1ecf7] bugfix: fix oracle insert undolog failed (apache#5556) Signed-off-by: slievrly <[email protected]> [0a1edf3] optimize: update expire gpg key and publish workflow (apache#5549) Signed-off-by: slievrly <[email protected]> [1c8e4bf] bugfix: the log file path was loaded incorrectly (apache#5531) [c73d72d] bugfix: fix GlobalStatus=9 can't be cleared in DB storage mode (apache#5523) [83493d9] optimize: optimize FenceHandler for oracle (apache#5519) [9b35ba9] bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g (apache#5498)
slievrly
reviewed
Jun 14, 2023
Member
slievrly
left a comment
There was a problem hiding this comment.
docker run --name seata-server -p 8091:8091 -p 7091:7091 -e JVM_XMX=1024m -e JVM_XMS=1024m -d seataio/seata-server:latest
Contributor
|
同步一份到develop分支提交pr |
1 task
1 task
2 tasks
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.Unified JVM parameters, they can be viewed in seata-setup.sh
2.Docker image supports JVM parameter injection.
Ⅱ. Does this pull request fix one issue?
fixes #5521
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've tested it localy.
1.Set some JVM parameters
2.See results
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
1.Use openjdk:8-jre-slim instead of openjdk:8u212-jre-alpine for JAVA8 platform, because the previous base image does not support bash commands.