optimize: optimize distributed lock log #5700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slievrly <[email protected]>
1 task
Signed-off-by: slievrly <[email protected]>
funky-eyes
reviewed
Jul 4, 2023
| } | ||
|
|
||
| private boolean ignoreSQLException(SQLException exception) { | ||
| if (IGNORE_MYSQL_CODE.contains(exception.getErrorCode())) { |
Contributor
There was a problem hiding this comment.
return IGNORE_MYSQL_CODE.contains(exception.getErrorCode()) ||
(StringUtils.isNotBlank(exception.getMessage()) && IGNORE_MYSQL_MESSAGE.stream().anyMatch(message -> exception.getMessage().contains(message)));
Member
Author
There was a problem hiding this comment.
Long bool judgment expressions are not recommended, as they become less readable.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize distributed lock log
Ⅱ. Does this pull request fix one issue?
fix #5684
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews