Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix: fix TC retry rollback wrongly, after the XA transaction fail and rollback #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 3 commits into from
Sep 15, 2023
Merged

bugfix: fix TC retry rollback wrongly, after the XA transaction fail and rollback #5835

funky-eyes merged 3 commits into from
Sep 15, 2023

Conversation

@capthua
Copy link
Contributor

@capthua capthua commented Sep 8, 2023 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复bug #5832 。当XA分支事务回滚后，报告给TC，避免TC不知道重试回滚

Ⅱ. Does this pull request fix one issue?

fixes #5832

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@capthua capthua changed the title bugfix: fix TC retry rollback wrongly, after the XA transaction fail … bugfix: fix TC retry rollback wrongly, after the XA transaction fail and rollback Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #5835 (6ec14f8) into 2.x (443eeaf) will increase coverage by 0.05%.
The diff coverage is 44.44%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5835      +/-   ##
============================================
+ Coverage     49.01%   49.06%   +0.05%     
- Complexity     4460     4467       +7     
============================================
  Files           821      821              
  Lines         28557    28557              
  Branches       3570     3570              
============================================
+ Hits          13996    14012      +16     
+ Misses        13104    13090      -14     
+ Partials       1457     1455       -2
Files Changed Coverage Δ
...a/io/seata/rm/datasource/xa/ConnectionProxyXA.java 56.49% <44.44%> (+1.94%) ⬆️

... and 6 files with indirect coverage changes

funky-eyes
funky-eyes approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.0.0 milestone Sep 15, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: XA XA transaction mode module/rm-datasource rm-datasource module labels Sep 15, 2023
@funky-eyes funky-eyes merged commit 4a3888b into apache:2.x Sep 15, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Sep 18, 2023
Closed
@zly123987123 zly123987123 mentioned this pull request Dec 27, 2023
Open
@Huoxi-any Huoxi-any mentioned this pull request Dec 28, 2023
Open
@Huoxi-any Huoxi-any mentioned this pull request Jan 6, 2024
Open
@zly123987123 zly123987123 mentioned this pull request Jan 6, 2024
Open
@xingfudeshi xingfudeshi mentioned this pull request Jan 30, 2024
Merged
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@capthua
bugfix: fix TC retry rollback wrongly, after the XA transaction fail …
879f71f 
…and rollback (apache#5835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

mode: XA XA transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

XA模式在某些情况下，分支事务已经回滚，但TC仍会重试回滚直到超时

2 participants

@capthua @funky-eyes