Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feature: support Dameng database #5932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slievrly merged 2 commits into from
Oct 16, 2023
Merged

feature: support Dameng database #5932

slievrly merged 2 commits into from
Oct 16, 2023

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Oct 15, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

#3672
#5884

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.0.0 milestone Oct 15, 2023
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. mode: AT AT transaction mode module/rm-datasource rm-datasource module module/sqlparser sql-parser module module/core core module module/common common module labels Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #5932 (01163f8) into 2.x (20662fd) will increase coverage by 0.72%.
The diff coverage is 67.75%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5932      +/-   ##
============================================
+ Coverage     48.80%   49.52%   +0.72%     
- Complexity     4485     4511      +26     
============================================
  Files           838      854      +16     
  Lines         28774    29876    +1102     
  Branches       3594     3660      +66     
============================================
+ Hits          14042    14795     +753     
- Misses        13257    13593     +336     
- Partials       1475     1488      +13
Files Coverage Δ
...n/src/main/java/io/seata/common/util/PageUtil.java 50.00% <ø> (ø)
...ql/distributed/lock/DistributedLockSqlFactory.java 0.00% <ø> (ø)
...o/seata/core/store/db/sql/lock/DmLockStoreSql.java 100.00% <100.00%> (ø)
...ta/core/store/db/sql/lock/LockStoreSqlFactory.java 75.00% <ø> (ø)
...io/seata/core/store/db/sql/log/DmLogStoreSqls.java 100.00% <100.00%> (ø)
...ource/sql/struct/cache/AbstractTableMetaCache.java 85.29% <100.00%> (ø)
...asource/sql/struct/cache/OracleTableMetaCache.java 67.30% <ø> (+0.96%) ⬆️
...ta/rm/datasource/undo/dm/DmUndoExecutorHolder.java 0.00% <0.00%> (ø)
.../sqlparser/druid/dm/DmOperateRecognizerHolder.java 0.00% <0.00%> (ø)
.../seata/rm/datasource/exec/dm/DmInsertExecutor.java 62.50% <62.50%> (ø)
... and 12 more

... and 2 files with indirect coverage changes

slievrly
slievrly approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit f709186 into apache:2.x Oct 16, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Oct 23, 2023
Closed
@Huoxi-any Huoxi-any mentioned this pull request Oct 27, 2023
Open
@zly123987123 zly123987123 mentioned this pull request Oct 28, 2023
Open
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@funky-eyes
feature: support Dameng database (apache#5932)
3ef53dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slievrly slievrly slievrly approved these changes

@wangliang181230 wangliang181230 Awaiting requested review from wangliang181230

Assignees

No one assigned

Labels

mode: AT AT transaction mode module/common common module module/core core module module/rm-datasource rm-datasource module module/sqlparser sql-parser module type: feature Category issues or prs related to feature request.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@funky-eyes @slievrly