Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@leizhiyuan
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5269

Ⅲ. Why don't you add test cases (unit test/integration test)?

image

Ⅳ. Describe how to verify it

  1. export JMX_ENABLE=true
  2. run in local machine, check the opts

Ⅴ. Special notes for reviews

@leizhiyuan
Copy link
Contributor Author

sync #5938 to develop branch

@leizhiyuan leizhiyuan requested a review from funky-eyes October 17, 2023 14:43
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to register the githubid in develop.md

@leizhiyuan
Copy link
Contributor Author

You also need to register the githubid in develop.md

done

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5939 (d00a889) into develop (971d1de) will decrease coverage by 0.03%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5939      +/-   ##
=============================================
- Coverage      48.86%   48.83%   -0.03%     
+ Complexity      4171     4167       -4     
=============================================
  Files            793      793              
  Lines          28003    28003              
  Branches        3417     3417              
=============================================
- Hits           13683    13676       -7     
- Misses         12895    12901       +6     
- Partials        1425     1426       +1     

see 6 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants