Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feature: add sqlserver's adaptation to the console paging interface #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 6 commits into from
Oct 22, 2023
Merged

feature: add sqlserver's adaptation to the console paging interface #5946

funky-eyes merged 6 commits into from
Oct 22, 2023

Conversation

@GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Oct 22, 2023 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

增加sqlserver对控制台接口的适配，主要增加对应类型的分页和计数SQL

Add the adaptation of sqlserver to the console interface, mainly adding corresponding types of paging and counting SQL

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes
funky-eyes approved these changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes closed this Oct 22, 2023
@funky-eyes funky-eyes reopened this Oct 22, 2023
@funky-eyes funky-eyes added this to the 2.0.0 milestone Oct 22, 2023
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/server server module labels Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Merging #5946 (b7100b7) into 2.x (5aca41d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5946      +/-   ##
============================================
- Coverage     49.76%   49.72%   -0.05%     
+ Complexity     4539     4538       -1     
============================================
  Files           854      854              
  Lines         29880    29883       +3     
  Branches       3660     3660              
============================================
- Hits          14869    14858      -11     
- Misses        13519    13531      +12     
- Partials       1492     1494       +2
Files Coverage Δ
...n/src/main/java/io/seata/common/util/PageUtil.java 55.17% <100.00%> (+5.17%) ⬆️

... and 6 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 2626f24 into apache:2.x Oct 22, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Oct 23, 2023
Closed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@GoodBoyCoder
feature: add sqlserver's adaptation to the console paging interface (a…
7c908df 
…pache#5946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

module/server server module type: feature Category issues or prs related to feature request.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@GoodBoyCoder @funky-eyes