-
Notifications
You must be signed in to change notification settings - Fork 8.9k
bugfix: fix the issue of Raft registry exception without waiting for retries #6049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6049 +/- ##
============================================
- Coverage 49.57% 49.49% -0.09%
- Complexity 4751 4752 +1
============================================
Files 907 908 +1
Lines 31295 31348 +53
Branches 3773 3777 +4
============================================
+ Hits 15515 15516 +1
- Misses 14247 14299 +52
Partials 1533 1533
|
...a-discovery-raft/src/main/java/io/seata/discovery/registry/raft/RaftRegistryServiceImpl.java
Outdated
Show resolved
Hide resolved
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6048
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews