Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Nov 17, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6048

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.0.0 milestone Nov 17, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/discovery discovery module labels Nov 17, 2023
@codecov
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #6049 (b23d9f0) into 2.x (545da73) will decrease coverage by 0.09%.
Report is 1 commits behind head on 2.x.
The diff coverage is 0.00%.

❗ Current head b23d9f0 differs from pull request most recent head 75b7a2e. Consider uploading reports for the commit 75b7a2e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6049      +/-   ##
============================================
- Coverage     49.57%   49.49%   -0.09%     
- Complexity     4751     4752       +1     
============================================
  Files           907      908       +1     
  Lines         31295    31348      +53     
  Branches       3773     3777       +4     
============================================
+ Hits          15515    15516       +1     
- Misses        14247    14299      +52     
  Partials       1533     1533              
Files Coverage Δ
...main/java/io/seata/common/util/HttpClientUtil.java 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@funky-eyes funky-eyes requested a review from slievrly November 17, 2023 09:53
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: registry type for raft under the network interruption did not carry out the sleep 1s bugfix: fix the issue of Raft registry exception without waiting for retries. Nov 18, 2023
@slievrly slievrly changed the title bugfix: fix the issue of Raft registry exception without waiting for retries. bugfix: fix the issue of Raft registry exception without waiting for retries Nov 18, 2023
@slievrly slievrly merged commit 27fc7ae into apache:2.x Nov 18, 2023
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/discovery discovery module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When all servers in a raft cluster are offline, the client's watch requests will loop indefinitely.

2 participants