optimize: zstd decompression is changed from jni to ZstdInputStream #7578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #7578 +/- ##
============================================
- Coverage 60.83% 60.78% -0.06%
+ Complexity 658 656 -2
============================================
Files 1308 1308
Lines 49432 49437 +5
Branches 5810 5811 +1
============================================
- Hits 30072 30049 -23
- Misses 16697 16724 +27
- Partials 2663 2664 +1
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes zstd decompression by switching from JNI-based approach to using ZstdInputStream for safer memory handling. The change prevents potential OOM attacks when decompressing maliciously crafted zstd data with fake frame content sizes.
- Replaced direct JNI decompression with streaming-based ZstdInputStream approach
- Updated exception handling to throw IllegalArgumentException instead of ZstdException
- Added comprehensive test coverage for OOM attack scenarios with fake frame content sizes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ZstdUtil.java | Refactored decompress method to use ZstdInputStream instead of direct JNI calls |
| ZstdUtilTest.java | Updated exception expectations and added new test for OOM attack prevention |
| changes/zh-cn/2.x.md | Added Chinese changelog entry for the optimization |
| changes/en-us/2.x.md | Added English changelog entry for the optimization |
Comments suppressed due to low confidence (1)
...essor/seata-compressor-zstd/src/test/java/org/apache/seata/compressor/zstd/ZstdUtilTest.java
Outdated
Show resolved
Hide resolved
…a/compressor/zstd/ZstdUtilTest.java Co-authored-by: Copilot <[email protected]>
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews